Updated to Boost 1.90 & Added Socks5 Proxy address parameter.#113
Merged
Conversation
… io_service with Io_context for Boost 1.90 compatiblity.
| }; | ||
|
|
||
|
|
||
| auto endpoints = resolver.resolve(host, std::to_string(port), ec); |
Owner
There was a problem hiding this comment.
use {} to assign instead of =
| boost_query query( host, std::to_string(port) ); | ||
| boost_endpoint socksEndpoint{ {}, static_cast<boost::asio::ip::port_type>(config.mining.socksPort) }; | ||
|
|
||
| boost::asio::ip::address_v4 addr = boost::asio::ip::make_address_v4(config.mining.socksIp); |
Owner
There was a problem hiding this comment.
use {} to assign instead of =
Add align column (indent)
|
|
||
| auto endpoints = resolver.resolve(host, std::to_string(port), ec); | ||
|
|
||
| if (ec || endpoints.begin() == endpoints.end()) |
Owner
There was a problem hiding this comment.
if (ec) is not explicit you need explicit compare example if (boost_error::success == ec)
| boost_query query{ host, std::to_string(port) }; | ||
| auto endpoints{ resolver.resolve(query, ec) }; | ||
|
|
||
| auto endpoints = resolver.resolve(host,std::to_string(port), |
Owner
There was a problem hiding this comment.
use {} to assign instead of =
| { | ||
| std::string msg; | ||
| msg.assign(boost::asio::buffer_cast<const char*>(recvBuffer.data()), bytes); | ||
| msg.assign(boost::asio::buffers_begin(recvBuffer.data()),boost::asio::buffers_begin(recvBuffer.data()) + bytes); |
| } | ||
| return 9050u; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
2 empty line between functions ;)
|
|
||
| auto const socksIp{ cli.getSocksIp() }; | ||
|
|
||
| mining.socksIp = socksIp; |
Owner
There was a problem hiding this comment.
You should check if socksIp is not empty, if value is empty logErr() a message and assin with default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've only tested this with a local ubuntu sock5 proxy server using Dante. It works. I decide to add an additional proxy ip parameter so it made it easier to connect to the VM.