fix(ios): resolve UIApplication delegate window nil crash on iOS 13+ SceneDelegate lifecycles#362
Open
jvallori wants to merge 2 commits intolukasgit:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a severe native iOS crash (
Unexpectedly found nil while unwrapping an Optional value) that occurs immediately upon initialization when the app utilizes iOS 13+UIScenemechanics (which is increasingly standard in modern Flutter ecosystem templates).The Bug
In
SwiftContactsServicePlugin.swift, therootViewControllerwas being rigidly extracted using the legacy application lifecycle model via a forced unwrap:UIApplication.shared.delegate!.window!!.rootViewController!Because modern iOS templates leverage
UISceneDelegatefor multi-window support rather than the legacyAppDelegate,delegate.windowcorrectly evaluates tonil, instantly crashing the application.The Fix
This PR introduces a backward-compatible resolution that dynamically scans
UIApplication.shared.connectedScenes(available on iOS 13.0+) to securely locate the activekeyWindowand binding to its root view controller natively. It safely falls back to the legacyUIApplication.shared.delegateif the device is running iOS 12 or if scenes are unsupported.Testing
UIScenelifecycle patterns cleanly.