Improve CI docs build and python dependency management#529
Improve CI docs build and python dependency management#529vpipkt wants to merge 4 commits intolocationtech:developfrom
Conversation
enable use of this in docs build Signed-off-by: Jason T. Brown <jason@astraea.earth>
This reverts commit a3e265d.
…Setup develop Signed-off-by: Jason T. Brown <jason@astraea.earth>
vpipkt
left a comment
There was a problem hiding this comment.
i'd like to get this merged before it gets real stale.
| pySetup.toTask(" pweave --quick True") | ||
| pySetup.toTask(" develop"), | ||
| pySetup.toTask(" pweave --quick True"), | ||
| pySetup.toTask(" develop --uninstall") // put environment back how it was |
There was a problem hiding this comment.
It seems like it would be good to have something like this:
pySetup.toTask(" develop"),
Try(pySetup.toTask(" pweave")),
pySetup.toTask(" develop --uninstall")
So that the environment is put back how it was (more or less?) after the pweave task runs even if it fails.
That's beyond my sbt fu though
There was a problem hiding this comment.
Another possibility is a much larger refactor:
- set up tox in pyrasterframes
- separate environments for unit tests and docs builds
- sbt task runs
tox -e $TOX_ENVIRONMENTinstead ofpython setup.py $SETUP_COMMAND
This would afford a chance to also carve out many of the setup_requires and declare specific requirements files for the disctinct tox environments.
There is possibly some downside I am not thinking of (other than the work of refactoring), but it occurred to me that this might be a good direction
|
Changed my mind and converted back to draft because there is still a bit of surgery to do in |
844c524 to
a5c6446
Compare
No description provided.