feat(imReadingABook): add new Spanish plugin for imreadingabook.com#2180
Open
anehemias6-star wants to merge 1 commit intolnreader:masterfrom
Open
feat(imReadingABook): add new Spanish plugin for imreadingabook.com#2180anehemias6-star wants to merge 1 commit intolnreader:masterfrom
anehemias6-star wants to merge 1 commit intolnreader:masterfrom
Conversation
K1ngfish3r
suggested changes
May 9, 2026
Collaborator
K1ngfish3r
left a comment
K1ngfish3r
left a comment
There was a problem hiding this comment.
missing novel summary, status and genres
https://www.imreadingabook.com/4-formas-de-encontrar-una-esposa/
looking at the novel, it does have summary, status, not sure about genres
the chapter titles dont tell much, recommend adding the volume title if possible
| icon = 'src/es/imreadingabook/icon.png'; | ||
| site = 'https://www.imreadingabook.com'; | ||
| version = '1.0.0'; | ||
| filters = undefined; |
Collaborator
There was a problem hiding this comment.
Suggested change
| filters = undefined; | |
| filters: Filters | undefined = undefined; |
| import { load as loadCheerio } from 'cheerio'; | ||
| import { NovelStatus } from '@libs/novelStatus'; | ||
| import { defaultCover } from '@libs/defaultCover'; | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| import { Filters } from '@libs/filterInputs'; | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Spanish plugin for imreadingabook.com, a site that translates Korean, Chinese and Japanese light novels to Spanish.