Skip to content

Add aarch64 SIMD specialization#82

Merged
llogiq merged 3 commits intomasterfrom
aarch64
Oct 1, 2023
Merged

Add aarch64 SIMD specialization#82
llogiq merged 3 commits intomasterfrom
aarch64

Conversation

@llogiq
Copy link
Copy Markdown
Owner

@llogiq llogiq commented Aug 27, 2023

I'm still without a good ARM CPU (but will hopefully get one, soon), but here's what I think should likely be the aarch64 intrinsics version of bytecount.

@Veedrac if you have a bit of time, I'd appreciate a review.

@llogiq llogiq requested a review from Veedrac August 27, 2023 00:08
@llogiq llogiq force-pushed the aarch64 branch 4 times, most recently from 7201a6f to c815bee Compare August 27, 2023 12:28
@llogiq
Copy link
Copy Markdown
Owner Author

llogiq commented Aug 27, 2023

There are still failing tests on aarch64. Notably the overflow_many tests fail for both count and num_chars. I'll look into that.

@Veedrac
Copy link
Copy Markdown
Collaborator

Veedrac commented Sep 11, 2023

Am I good to wait for the tests to be fixed before reviewing, or would you prefer a review sooner?

@llogiq
Copy link
Copy Markdown
Owner Author

llogiq commented Sep 11, 2023

Yeah, I need to find a few hours. I think I know what's wrong, just need to fix things. I'll ping you.

@llogiq
Copy link
Copy Markdown
Owner Author

llogiq commented Sep 17, 2023

@Veedrac if all goes well, CI should be green soon. I've checked that perf matches the packed_simd variant on a M2 macbook and my mobile phone (using the bootstrap trick).

@llogiq
Copy link
Copy Markdown
Owner Author

llogiq commented Sep 23, 2023

@Veedrac CI is most certainly green. I'm tempted to just bump the version, push and publish it.

@llogiq
Copy link
Copy Markdown
Owner Author

llogiq commented Oct 1, 2023

I'm going to merge this now; it's fared well in all my tests, and if there's anything wrong, we can fix it in a followup PR.

@llogiq llogiq merged commit b375732 into master Oct 1, 2023
@llogiq llogiq deleted the aarch64 branch October 1, 2023 12:16
@xtqqczze
Copy link
Copy Markdown

This apparently bumped MSRV to 1.61, see #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants