design: #6 hybrid on-chain pair transport — design doc#31
Open
hanwencheng wants to merge 1 commit intomainfrom
Open
design: #6 hybrid on-chain pair transport — design doc#31hanwencheng wants to merge 1 commit intomainfrom
hanwencheng wants to merge 1 commit intomainfrom
Conversation
Draft design doc for GitHub issue #6 (replace rendezvous relay + auth_requests state machine with on-chain pair transport, Pattern 4 decoupled). Ships ONLY the doc. Implementation is blocked on: (a) Pattern 4 infrastructure (issue #5) shipping first, (b) Heima pallet feasibility review by Kai, (c) sign-off on the 5 open questions at the bottom of the doc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Codex review (via gstack VerdictThe patch only adds a design document and does not modify executable code, tests, or existing behavior. I did not find any discrete, actionable issues in the diff that would break current functionality or make the repository incorrect. — codex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft design doc for issue #6. Documents the target on-chain pair transport (chain-indexed PairRequest + ApprovePair extrinsics, TTL at the pallet level, VVC derived client-side from the signature, Pattern 4 decoupled serve/audit).
Key design refinements (locked in issue body)
valid_untilis a first-class on-chain field; pallet rejects expired approvals.Net LOC impact
~665 LOC removed (rendezvous + auth_requests + long-poll), ~200 LOC added (chain-event simulation) = net ~465 LOC reduction in the mock backend.
Review ask
Please review and answer the 5 open questions at the bottom of the doc:
Test plan
Docs-only. No code impact.
Issue
Tracks #6. Implementation blocked on #5 (Pattern 4 infra) + Kai's pallet review.
🤖 Generated with Claude Code
Codex review (2026-04-14): ✅ Approved — no actionable findings. See the codex comment above for details.