Conversation
CatarinaGamboa
requested changes
May 14, 2025
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Add tests to our testsuit
Collaborator
|
Are there any news in this PR? @Pichers |
CatarinaGamboa
requested changes
May 21, 2025
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Add some more test cases for using values after the if condition like:
this.value = n;
if (x){
this.value = k;
}
return this.value;
CatarinaGamboa
requested changes
Jun 13, 2025
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
These tests are better but still do not test what I tried to mention last time, see the comments in the PR
| this.next = next; | ||
| } | ||
|
|
||
| public Object test(@Free Object v1, boolean c1){ |
Collaborator
There was a problem hiding this comment.
Create at least one more separate test where we check if the return type has the permission required after the if conditions.
For the previous example check if the return is still @Unique for example (might need changes):
public @Unique Object test(@Free Object v1, boolean c1){
Object n;
n = new Object(); // n is free
this.value = n; // should be fine
if (c1){
this.value = v1; // should be fine
}
return this.value; // is this.value still Unique?
}This way we can check if the information in the context is the expected one.
CatarinaGamboa
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simulated an "Else { skip; }" when no else expression is present in the original code.
Related Issue
Closes #11
Type of change
How Has This Been Tested?
Some simple feature tests were ran locally, with no found bugs