Fix: When the control center opens the disclaimer box, extra icon lab…

[MyLeeJiEun]

…els are displayed on the taskbar.

In X11 mode, add the Qt::Tool flag to the window's flags and disable the taskbar display.

Log: Fixed the issue of extra icons displayed in the taskbar under X11 by adding the Qt::Tool flag. PMS:

fix: 控制中心打开免责声明框时任务栏展示多余图标标签

在X11模式下为窗口标志添加Qt::Tool标志，过滤任务栏显示

Log: 通过添加Qt::Tool标志修复X11下任务栏显示多余标志

PMS: BUG-359493

Summary by Sourcery

Bug Fixes:

• Ensure the license dialog in X11 uses a tool-style window so it no longer appears as an extra icon in the taskbar.

[deepin-ci-robot]

Hi @MyLeeJiEun. Thanks for your PR. 😃

[deepin-ci-robot]

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the dde-license-dialog main window flags so that under X11 the disclaimer dialog uses Qt::Tool in addition to staying on top, preventing it from creating an extra taskbar icon while keeping existing Wayland behavior unchanged.

Sequence diagram for opening the disclaimer dialog with different window flags on Wayland vs X11

sequenceDiagram
    actor User
    participant ControlCenter
    participant MainWindow
    participant WindowManager

    User->>ControlCenter: openDisclaimer()
    ControlCenter->>MainWindow: MainWindow(parent)
    alt Wayland
        MainWindow->>MainWindow: setWindowFlags(windowFlags | Qt.FramelessWindowHint | Qt.WindowStaysOnTopHint)
    else X11
        MainWindow->>MainWindow: setWindowFlags(windowFlags | Qt.WindowStaysOnTopHint | Qt.Tool)
    end
    MainWindow->>WindowManager: show()
    Note over WindowManager: X11 + Qt.Tool prevents extra taskbar icon

Loading

File-Level Changes

Change	Details	Files
Adjust window flags for the license dialog under X11 to prevent extra taskbar icons while keeping it always on top.	Detect non-Wayland (X11) mode by reusing the existing bWayland boolean branch. Add Qt::Tool to the window flags alongside Qt::WindowStaysOnTopHint when not running under Wayland. Leave Wayland-specific window flags logic unchanged to avoid regressions there.	dde-license-dialog/src/mainwindow.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment