fix(touchpad): correct DConfig key name for gesture enabled#1108
Conversation
Use "touchPadEnabled" to match the key defined in org.deepin.dde.daemon.gesture schema, fixing touchpad gestures remaining active after disabling the touchpad. 修复触控板禁用后手势仍然可用的问题,DConfig key 名称大小写不匹配导致写入了错误的配置项。 Log: 修复禁用触控板后手势仍然可用的bug PMS: 360815 Influence: 禁用触控板后,触控板手势正确停止响应
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 52cyb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @52cyb. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the DConfig key used to control whether gestures are enabled on the touchpad so that it matches the actual schema key, ensuring gestures correctly follow the touchpad enabled state. Sequence diagram for updated touchpad gesture DConfig key handlingsequenceDiagram
participant Touchpad
participant Gesture
participant DConfig
Touchpad->>Gesture: enableGesture(enabled)
Gesture->>DConfig: GetValueBool(touchPadEnabled)
alt value equals enabled
Gesture-->>Touchpad: return (no change)
else value differs
Gesture->>DConfig: SetValue(touchPadEnabled, enabled)
DConfig-->>Gesture: ack
Gesture-->>Touchpad: return
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The DConfig key name is now fixed in two places; consider extracting it into a shared constant to avoid future casing/typo bugs.
enableGestureignores errors fromGetValueBoolandSetValue; handling or logging these errors would make failures in DConfig access easier to diagnose.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The DConfig key name is now fixed in two places; consider extracting it into a shared constant to avoid future casing/typo bugs.
- `enableGesture` ignores errors from `GetValueBool` and `SetValue`; handling or logging these errors would make failures in DConfig access easier to diagnose.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Use "touchPadEnabled" to match the key defined in org.deepin.dde.daemon.gesture schema, fixing touchpad gestures remaining active after disabling the touchpad.
修复触控板禁用后手势仍然可用的问题,DConfig key 名称大小写不匹配导致写入了错误的配置项。
Log: 修复禁用触控板后手势仍然可用的bug
PMS: 360815
Influence: 禁用触控板后,触控板手势正确停止响应
Summary by Sourcery
Bug Fixes: