Skip to content

fix(touchpad): correct DConfig key name for gesture enabled#1108

Open
52cyb wants to merge 1 commit into
linuxdeepin:masterfrom
52cyb:master
Open

fix(touchpad): correct DConfig key name for gesture enabled#1108
52cyb wants to merge 1 commit into
linuxdeepin:masterfrom
52cyb:master

Conversation

@52cyb
Copy link
Copy Markdown
Contributor

@52cyb 52cyb commented May 15, 2026

Use "touchPadEnabled" to match the key defined in org.deepin.dde.daemon.gesture schema, fixing touchpad gestures remaining active after disabling the touchpad.

修复触控板禁用后手势仍然可用的问题,DConfig key 名称大小写不匹配导致写入了错误的配置项。

Log: 修复禁用触控板后手势仍然可用的bug
PMS: 360815
Influence: 禁用触控板后,触控板手势正确停止响应

Summary by Sourcery

Bug Fixes:

  • Ensure disabling the touchpad correctly disables touchpad gestures by aligning the DConfig key name with the gesture daemon schema.

Use "touchPadEnabled" to match the key defined in org.deepin.dde.daemon.gesture schema, fixing touchpad gestures remaining active after disabling the touchpad.

修复触控板禁用后手势仍然可用的问题,DConfig key 名称大小写不匹配导致写入了错误的配置项。

Log: 修复禁用触控板后手势仍然可用的bug
PMS: 360815
Influence: 禁用触控板后,触控板手势正确停止响应
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

Hi @52cyb. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 15, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the DConfig key used to control whether gestures are enabled on the touchpad so that it matches the actual schema key, ensuring gestures correctly follow the touchpad enabled state.

Sequence diagram for updated touchpad gesture DConfig key handling

sequenceDiagram
    participant Touchpad
    participant Gesture
    participant DConfig

    Touchpad->>Gesture: enableGesture(enabled)
    Gesture->>DConfig: GetValueBool(touchPadEnabled)
    alt value equals enabled
        Gesture-->>Touchpad: return (no change)
    else value differs
        Gesture->>DConfig: SetValue(touchPadEnabled, enabled)
        DConfig-->>Gesture: ack
        Gesture-->>Touchpad: return
    end
Loading

File-Level Changes

Change Details Files
Align DConfig key name for touchpad gesture enablement with schema to ensure correct configuration is read and written.
  • Update the boolean read for gesture enablement to use the correct DConfig key name
  • Update the configuration write for gesture enablement to use the correct DConfig key name
inputdevices1/touchpad.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The DConfig key name is now fixed in two places; consider extracting it into a shared constant to avoid future casing/typo bugs.
  • enableGesture ignores errors from GetValueBool and SetValue; handling or logging these errors would make failures in DConfig access easier to diagnose.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The DConfig key name is now fixed in two places; consider extracting it into a shared constant to avoid future casing/typo bugs.
- `enableGesture` ignores errors from `GetValueBool` and `SetValue`; handling or logging these errors would make failures in DConfig access easier to diagnose.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants