Conversation
This will be shared by both D-Bus interfaces, so we should consolidate it there.
This isn't clean, but I'll have to see how it works on in the xdp code to see if this is desirable or not. Maybe we'll wind up splitting into two parameters.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the necessary changes for xdg-desktop-portal to initiate the request to credentialsd. Once this is ready, this will become the primary interface for interacting with credentialsd.
Unfortunately, this is a huge PR. Some highlights of changes:
originis now required to be set.top_origincan now be sent inoptions.json.options.activation_tokenoptional parameter, but credentialsd doesn't do anything with it yet.In order to test this, you need to run iinuwa/xdg-desktop-portal@65f21d3 with the
XDG_DESKTOP_PORTAL_ENABLE_EXPERIMENTAL=credentialenvironment variable set, as well as having the impl portal stub defined in~/.local/share/xdg-desktop-portal/portals/credentialsd.portaland having
~/.config/xdg-desktop-portal/<desktop-environment>.configpopulated withThis should allow xdg-desktop-portal to start the Credential portal at
org.freedesktop.portal.experimental.Credential. (You can use D-Spy, busctl, or some other introspection to verify whether the interface was started.)