Conversation
Replace underscore-separated method names with camelCase equivalents (e.g., 'гуруҳ_охир' → 'гуруҳОхир', 'вақт_сабт' → 'вақтСабт') for consistency with Tajik naming conventions. Updated 80+ identifier mappings across: - Array methods (copyWithin, findIndex, flatMap, forEach, etc.) - String methods (charAt, codePointAt, padStart, replaceAll, etc.) - Math methods (acosh, asinh, atanh, hypot, etc.) - Object methods (defineProperties, getOwnPropertyDescriptor, etc.) All tests passing (1233 tests).
Replace all instances of 'тағйирёбанда' with the shorter 'тағ' keyword throughout the quick-start documentation and related test files. Changes: - docs/reference/quick-start.md: Update all variable declarations - tests/stdlib-array.test.ts: Update test setup code - tests/stdlib-string.test.ts: Update test setup code This aligns the documentation and tests with the new short keyword introduced for improved code brevity.
Add support for using built-in identifiers and keywords as function parameter names, enabling proper parsing of arrow functions with Tajik method names. Update examples to use new camelCase naming convention. Changes: - parser.ts: Allow built-in identifiers and keywords as parameter names - examples/29-generics.som: Replace ҷудокунӣ with пайвастКардан - examples/35-advanced-backend-patterns.som: Remove unnecessary await keywords
|
✅ Tests completed on Node.js 20.x: success |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add support for underscore-separated variants of camelCase method names to maintain backward compatibility (e.g., 'гуруҳ_охир' alongside 'гуруҳОхир', 'вақт_сабт' alongside 'вақтСабт'). Changes: - codegen.ts: Add underscore variants to builtin mappings for console methods (гуруҳ_охир, гуруҳ_пӯшида, вақт_охир, вақт_сабт, қайд_асл, xml_феҳрист) and string methods (сатр_
|
@codex review |
|
✅ Tests completed on Node.js 20.x: success |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
https://github.com/codex review |
|
❌ Tests completed on Node.js 20.x: failure |
|
|
✅ Tests completed on Node.js 20.x: success |
2 participants
🎉 Pull Request
Description
Type of Change
to not work as expected)
Related Issue
Fixes #(issue number)
Changes Made
Testing
npm test)npm run lint)npm run type-check)Checklist
Additional Context
📋 License Information
SomonScript is open source software licensed under the MIT License.
By submitting this pull request, you agree that your contributions will be
licensed under the MIT License.
For contribution guidelines, please review:
guidelines
Thank you for contributing to SomonScript! 🚀