Skip to content

LCORE-1957: Removed dev-tools/mcp-server#1562

Open
jrobertboos wants to merge 2 commits intolightspeed-core:mainfrom
jrobertboos:lcore-1957
Open

LCORE-1957: Removed dev-tools/mcp-server#1562
jrobertboos wants to merge 2 commits intolightspeed-core:mainfrom
jrobertboos:lcore-1957

Conversation

@jrobertboos
Copy link
Copy Markdown
Contributor

@jrobertboos jrobertboos commented Apr 21, 2026

Description

Consolidates the MCP mock server infrastructure by removing the duplicate dev-tools/mcp-mock-server and standardizing on the tests/e2e/mock_mcp_server implementation. This simplifies the test infrastructure by:

  • Removing the entire dev-tools/mcp-mock-server directory and its associated documentation
  • Updating the mock-mcp service to use port 3000 (previously used by the removed server)
  • Removing mcp-mock-server service dependencies from docker-compose files
  • Renaming config file mcp-mock-server.yaml to mock-mcp.yaml
  • Moving the MCP client auth options test from info.feature to mcp.feature for better test organization

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: Claude Code
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue # LCORE-1957
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  1. Run e2e tests with docker-compose to verify mock-mcp service works on port 3000:
    docker-compose up -d
    uv run make test-e2e
  2. Verify MCP-related test scenarios pass, particularly:
  • MCP OAuth authentication tests
  • MCP client auth options endpoint test (now in mcp.feature)
  • MCP server management API tests
  1. Confirm the mcp-mock-server service is no longer referenced in any configuration

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Warning

Rate limit exceeded

@jrobertboos has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 5 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 5 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2391c820-d12f-473e-acf6-4eeff2c1a08b

📥 Commits

Reviewing files that changed from the base of the PR and between ca47172 and 845abd4.

📒 Files selected for processing (39)
  • .gitignore
  • README.md
  • dev-tools/MANUAL_TESTING.md
  • dev-tools/README.md
  • dev-tools/mcp-mock-server/Dockerfile
  • dev-tools/mcp-mock-server/README.md
  • dev-tools/mcp-mock-server/server.py
  • dev-tools/mcp-mock-server/test_mock_mcp_server.py
  • dev-tools/test-configs/llama-stack-mcp-test.yaml
  • dev-tools/test-configs/mcp-mock-test.yaml
  • docker-compose-library.yaml
  • docker-compose.yaml
  • docs/e2e_testing.md
  • tests/e2e-prow/rhoai/manifests/lightspeed/mock-mcp.yaml
  • tests/e2e-prow/rhoai/pipeline-konflux.sh
  • tests/e2e-prow/rhoai/pipeline.sh
  • tests/e2e/configuration/library-mode/lightspeed-stack-invalid-mcp-file-auth.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-mcp-auth.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-mcp-client-auth.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-mcp-file-auth.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-mcp-kubernetes-auth.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-mcp-oauth-auth.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-mcp.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-invalid-mcp-file-auth.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-mcp-auth.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-mcp-client-auth.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-mcp-file-auth.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-mcp-kubernetes-auth.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-mcp-oauth-auth.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-mcp.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack.yaml
  • tests/e2e/features/info.feature
  • tests/e2e/features/llama_stack_disrupted.feature
  • tests/e2e/features/mcp.feature
  • tests/e2e/features/mcp_servers_api.feature
  • tests/e2e/features/mcp_servers_api_auth.feature
  • tests/e2e/mock_mcp_server/Dockerfile
  • tests/e2e/mock_mcp_server/server.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jrobertboos
Copy link
Copy Markdown
Contributor Author

Please Review

@jrobertboos jrobertboos marked this pull request as ready for review April 21, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant