feat: add EUR account info, beneficiary, and external account schemas#216
feat: add EUR account info, beneficiary, and external account schemas#216AaryamanBhute wants to merge 1 commit intochanges-presentfrom
Conversation
Add SEPA/EUR support with IBAN and optional BIC fields, covering Eurozone countries. Registers EUR_ACCOUNT across all discriminators, payment instructions, and external account types. Co-authored-by: Cursor <cursoragent@cursor.com>
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-python studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-typescript studio · code · diff
✅ grid-openapi studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis PR adds comprehensive EUR account support to the OpenAPI specification, following the established patterns used for GBP, USD, and CAD accounts. The implementation includes Key changes:
The implementation is clean, consistent, and follows the repository's established conventions for adding currency-specific account schemas. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/EurAccountInfo.yaml | New EUR account schema with IBAN/BIC fields, SEPA rail, and 19 Eurozone countries - follows existing patterns |
| openapi/components/schemas/common/EurBeneficiary.yaml | EUR individual beneficiary schema - identical structure to GbpBeneficiary, consistent with existing patterns |
| openapi/components/schemas/external_accounts/EurExternalAccountInfo.yaml | EUR external account combining base info, account info, and beneficiary discriminator - matches GBP pattern |
| openapi/components/schemas/common/PaymentEurAccountInfo.yaml | EUR payment account with reference field - consistent with GBP/CAD/USD patterns |
| openapi/components/schemas/external_accounts/ExternalAccountType.yaml | Added EUR_ACCOUNT to external account type enum - alphabetically ordered |
| openapi/components/schemas/common/PaymentAccountType.yaml | Added EUR_ACCOUNT to payment account type enum - alphabetically ordered |
Entity Relationship Diagram
%%{init: {'theme': 'neutral'}}%%
erDiagram
EurAccountInfo {
string accountType "EUR_ACCOUNT"
array countries "19 Eurozone countries"
array paymentRails "SEPA"
string iban "Required - pattern validated"
string bic "Optional - SWIFT code"
}
EurBeneficiary {
string beneficiaryType "INDIVIDUAL"
string fullName "Required"
string birthDate "Optional"
string nationality "Optional"
string email "Optional"
string phoneNumber "Optional"
string registrationNumber "Optional"
string countryOfResidence "Optional"
object address "Optional"
}
BusinessBeneficiary {
string beneficiaryType "BUSINESS"
string legalName "Required"
string registrationNumber "Optional"
string taxId "Optional"
string email "Optional"
string phoneNumber "Optional"
string countryOfResidence "Optional"
object address "Optional"
}
EurExternalAccountInfo {
string accountType "Inherited"
object beneficiary "Required"
}
PaymentEurAccountInfo {
string accountType "Inherited"
string reference "Required - UMA reference code"
}
BaseExternalAccountInfo ||--|| EurExternalAccountInfo : extends
EurAccountInfo ||--|| EurExternalAccountInfo : extends
EurExternalAccountInfo ||--o{ EurBeneficiary : "beneficiary (oneOf)"
EurExternalAccountInfo ||--o{ BusinessBeneficiary : "beneficiary (oneOf)"
BasePaymentAccountInfo ||--|| PaymentEurAccountInfo : extends
EurAccountInfo ||--|| PaymentEurAccountInfo : extends
Last reviewed commit: 3d3b5da
Summary
EurAccountInfoschema with IBAN (required), optional BIC, SEPA payment rail, and 19 Eurozone country codesEurBeneficiaryschema for individual beneficiaries (matching existing currency patterns)EurExternalAccountInfocombining base external account info, EUR account info, and beneficiary (Individual/Business) discriminatorPaymentEurAccountInfowith reference field (matching GBP/USD/CAD pattern)EUR_ACCOUNTin all discriminators and enums:ExternalAccountType,PaymentAccountType,ExternalAccountInfoOneOf,BaseExternalAccountInfo,BasePaymentAccountInfo, andPaymentInstructionsTest plan
make buildpasses — OpenAPI spec bundles successfullymake lintpasses — Redocly validation and Mintlify openapi-check both cleanMade with Cursor