Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript ✅ grid-python studio · code
✅ grid-kotlin studio · code
✅ grid-typescript studio · code
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummarySchema field renaming to standardize ID naming across three resources: Quote, BulkCustomerImportJob, and BaseWebhook now use Changes:
Note: The previous review thread identified that webhook example files still reference the old field names ( Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/quotes/Quote.yaml | Renamed quoteId to id in schema definition - clean schema change |
| openapi/components/schemas/customers/BulkCustomerImportJob.yaml | Renamed jobId to id in schema definition - clean schema change |
| openapi/components/schemas/webhooks/BaseWebhook.yaml | Renamed webhookId to id in schema definition - clean schema change |
Class Diagram
%%{init: {'theme': 'neutral'}}%%
classDiagram
class Quote {
-id string
-status string
-expiresAt datetime
-createdAt datetime
}
class BulkCustomerImportJob {
-id string
-status string
-progress object
}
class BaseWebhook {
-id string
-timestamp datetime
-type string
}
class OutgoingTransaction {
-id string
-quoteId string
-customerId string
}
OutgoingTransaction --> Quote : references via quoteId
note for Quote "Changed: quoteId → id"
note for BulkCustomerImportJob "Changed: jobId → id"
note for BaseWebhook "Changed: webhookId → id"
Last reviewed commit: fa20a23
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 86
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 121
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/test-webhook.yaml
Line: 49
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/kyc-status.yaml
Line: 63
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/invitation-claimed.yaml
Line: 72
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 100
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 126
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 55
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 77
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/account-status.yaml
Line: 69
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
pengying
force-pushed
the
02-18-feat_fixing_transaction_schema
branch
from
36ee105 to
c774ff0
Compare
pengying
force-pushed
the
02-18-fix_correcting_resource_id_names
branch
from
b804868 to
2cc78d7
Compare
![restamp-bot[bot]](https://avatars.githubusercontent.com/u/103385173?s=60&v=4){kind=small}
There was a problem hiding this comment.
needs to be id not quoteId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 72
Comment:
needs to be `id` not `quoteId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 86
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not quoteId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 107
Comment:
needs to be `id` not `quoteId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 121
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not jobId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 47
Comment:
needs to be `id` not `jobId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 126
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/account-status.yaml
Line: 69
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/test-webhook.yaml
Line: 49
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/kyc-status.yaml
Line: 63
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
needs to be id not webhookId
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/webhooks/invitation-claimed.yaml
Line: 72
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
pengying
force-pushed
the
02-18-feat_fixing_transaction_schema
branch
from
c774ff0 to
eb98c72
Compare
pengying
force-pushed
the
02-18-fix_correcting_resource_id_names
branch
from
2cc78d7 to
dd4ab48
Compare
Additional Comments (21)
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 139
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 96
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 177
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/account-status.yaml
Line: 88
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/test-webhook.yaml
Line: 69
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/kyc-status.yaml
Line: 81
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/invitation-claimed.yaml
Line: 90
Comment:
Update error description to reference `id` instead of `webhookId`
```suggestion
description: Conflict - Webhook has already been processed (duplicate id)
```
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 72
Comment:
Should be `id` not `quoteId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 86
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 107
Comment:
Should be `id` not `quoteId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 121
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 47
Comment:
Should be `id` not `jobId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 55
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 62
Comment:
Should be `id` not `jobId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 77
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 100
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 126
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/account-status.yaml
Line: 69
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/test-webhook.yaml
Line: 49
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/kyc-status.yaml
Line: 63
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/invitation-claimed.yaml
Line: 72
Comment:
Should be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise. |
pengying
force-pushed
the
02-18-feat_fixing_transaction_schema
branch
from
eb98c72 to
8ad3ce8
Compare
pengying
force-pushed
the
02-18-fix_correcting_resource_id_names
branch
from
dd4ab48 to
2d628a2
Compare
Additional Comments (14)
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 47
Comment:
needs to be `id` not `jobId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 62
Comment:
needs to be `id` not `jobId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 55
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/bulk-upload.yaml
Line: 77
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 72
Comment:
needs to be `id` not `quoteId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 107
Comment:
needs to be `id` not `quoteId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 86
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/outgoing-payment.yaml
Line: 121
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 100
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/incoming-payment.yaml
Line: 126
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/account-status.yaml
Line: 69
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/test-webhook.yaml
Line: 49
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/kyc-status.yaml
Line: 63
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/webhooks/invitation-claimed.yaml
Line: 72
Comment:
needs to be `id` not `webhookId`
How can I resolve this? If you propose a fix, please make it concise. |
pengying
force-pushed
the
02-18-feat_fixing_transaction_schema
branch
from
8ad3ce8 to
33406c9
Compare
pengying
force-pushed
the
02-18-fix_correcting_resource_id_names
branch
from
2d628a2 to
d2022db
Compare
pengying
changed the base branch from
02-18-feat_fixing_transaction_schema
to
graphite-base/208
pengying
force-pushed
the
02-18-fix_correcting_resource_id_names
branch
from
d2022db to
fa20a23
Compare
pengying
force-pushed
the
graphite-base/208
branch
from
33406c9 to
5b33dc7
Compare
graphite-app
bot
dismissed stale reviews from restamp-bot[bot] and shreyav
The base branch was changed.
2 participants
TL;DR
Standardized ID field names across API schemas by renaming specific identifier fields to simply
id.What changed?
Renamed identifier fields in three schema components to follow a consistent naming pattern:
quoteIdtoidin the Quote schemajobIdtoidin the BulkCustomerImportJob schemawebhookIdtoidin the BaseWebhook schemaThese changes were applied to both the combined OpenAPI file and the individual component files.
How to test?
Why make this change?
This change standardizes our API response format by using consistent field naming conventions across all resources. Having a uniform
idfield instead of resource-specific identifiers (quoteId,jobId,webhookId) makes the API more intuitive and easier to work with for developers.