fix: retry model deletion on Windows when files are locked#53
Open
Bortlesboat wants to merge 1 commit intolightningpixel:mainfrom
Open
fix: retry model deletion on Windows when files are locked#53Bortlesboat wants to merge 1 commit intolightningpixel:mainfrom
Bortlesboat wants to merge 1 commit intolightningpixel:mainfrom
Conversation
After unloading a model, Windows may still hold file locks briefly. Add await on unload response and retry logic with backoff for EBUSY/EPERM errors during directory removal. Fixes lightningpixel#12 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rmup to 3 times with incremental backoff (1s, 2s, 3s) when the error isEBUSYorEPERMDetails
On Windows, when a model is loaded into memory by the Python backend, the OS holds file locks on the model directory. The existing
model:deletehandler fires the unload request without awaiting it, then immediately attemptsrm— which fails withEBUSYorEPERMbecause handles haven't been released yet.This fix makes the unload blocking (with a 10s timeout) and adds retry logic so transient lock failures are handled gracefully.
Only the
model:deleteIPC handler inelectron/main/ipc-handlers.tsis modified.Fixes #12
Test plan
🤖 Generated with Claude Code