fix: BugOrBroken - partially-shadowed object has nested delayed merge#846
Merged
johanandren merged 1 commit intomainfrom May 5, 2026
Merged
fix: BugOrBroken - partially-shadowed object has nested delayed merge#846johanandren merged 1 commit intomainfrom
johanandren merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.4.7 fix for #838 (commit 833bacb) added per-key pruning that built a new
SimpleConfigObjectcontaining only the unshadowed keys and substituted it for end before resolving. The outerConfigDelayedMergeObjectstill referenced the original (unpruned) end in its stack, so any innerConfigDelayedMergewhose resolution walked the parent chain back up failedreplaceChildInListwith:This fixes that by narrowing the pruning to a whole-entry skip: only continue when every key in end is shadowed by an ignoresFallbacks value in merged. Never substitute a partial copy of end, that changes identity and breaks the parent-chain walk.