Correct bounds construction in native_window_set_bounds#34
Merged
Conversation
Co-authored-by: lijy91 <3889523+lijy91@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix width and height order in native_window_set_bounds
Correct bounds construction in native_window_set_bounds
Jan 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in native_window_set_bounds where the width and height parameters were swapped when constructing the Rectangle object, causing incorrect window geometry updates.
- Corrected Rectangle initialization to use the proper order:
{x, y, width, height}instead of{x, y, height, width}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
native_window_set_boundsbuilt the Rectangle with height/width swapped, causing incorrect geometry updates.{x, y, width, height}before callingSetBounds.Example:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.