Fixes crash caused by GTRepository dealloc#690
Open
arguiot wants to merge 1 commit intolibgit2:masterfrom
Open
Fixes crash caused by GTRepository dealloc#690arguiot wants to merge 1 commit intolibgit2:masterfrom
arguiot wants to merge 1 commit intolibgit2:masterfrom
Conversation
arguiot
changed the title
arguiot
added a commit
to arguiot/StudIO
that referenced
this pull request
May 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the system calls
-[GTRepository dealloc]and the git_repository is empty, but still exists, the app crashes.Here is a screenshot of the debug session:
To fix this, the function is simply checking if the
workdirproperty of thegit_repositoryobject isn't empty before cleaning the repo.This PR fixes #689