Open
Conversation
tiennou
reviewed
Oct 27, 2018
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /usr/bin/python; | ||
| shellScript = "# encoding=utf-8\n\nimport os, time, codecs\nroot = os.getenv('SRCROOT')\nprint \"update localisation in\", root\nfor (dirpath, dirnames, filenames) in os.walk(root):\n if \"en.lproj\" in dirnames:\n os.chdir(dirpath)\n os.system(\"find ./ -name '*.mm' -o -name '*.m' | xargs genstrings -u -q -o en.lproj\")\n"; |
Contributor
There was a problem hiding this comment.
Can you split that into ./script/update-localization ? That would be ❤️, as that would save my soul from Xcode make it much easier to edit.
tiennou
reviewed
Oct 27, 2018
Contributor
tiennou
left a comment
tiennou
left a comment
There was a problem hiding this comment.
Thanks for trying to tackle this. I'm not in a position to benefit from it yet (GitX doesn't even have correct localization support), but it's always nice to have support for i18n.
A few points :
- as I alluded to in #658, I think the first "mission" would be to fix our
-[NSError git_errorWithCode:description:…]method, because it's not amenable to correct error messages. So either it should be removed in favor of-git_errorWithCode:description:failureReason:…(which forces a revisit of all localizable strings), or it should be renamed to-git_errorWithCode:failureReason:…, with a generic@"An error occurred"description (though the failure reason would still read strangely IMHO). - I'd like to have the localization comments be helpful. My current comment pattern in GitX looks like this, so something like
@"classname - description of what it's used for". If we want to tackle localization, I'd prefer to have a good set of "rules" before moving on.
| PRODUCT_NAME = "$(TARGET_NAME)"; | ||
| }; | ||
| name = Profile; | ||
| }; |
Contributor
There was a problem hiding this comment.
This hunk should be left out — that's codesigning configuration.
| CreatedOnToolsVersion = 9.4.1; | ||
| DevelopmentTeam = X2L8375ZQ7; | ||
| ProvisioningStyle = Automatic; | ||
| }; |
Contributor
There was a problem hiding this comment.
Unwanted codesigning hunk.
Contributor
Author
There was a problem hiding this comment.
Removed that. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.