fix: resolve extended text box save issue when question title has a c…#2
Open
liviacarolgouvea wants to merge 1 commit intolepidus:mainfrom
Open
Conversation
Member
|
Obrigado, @liviacarolgouvea ! Como essa mudança quebra os testes cypress atuais, vamos precisar mudar também os testes. E há a questão de compatibilidade das questões salvas em instalações correntes, com os nomes da forma atual. Em breve esperamos lançar a versão nova com as correções. |
Member
|
Olá @liviacarolgouvea, Lançamos uma nova versão do plugin a correção do nome das perguntas no formulário: v1.1.0.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The form's fieldName generation was based on the custom question's title.
If the title contained a comma, it would generate an invalid HTML ID/CSS selector that caused the TinyMCE initialization to silently fail in the frontend, preventing the value from being saved.
Updated fieldName to use a static and safe prefix ('customQuestion-') alongside the custom question ID.