feat: add random punctuation to generated word lists and update documentation to reflect this behavior#60
Open
johnny603 wants to merge 1 commit intolemnos:masterfrom
Open
feat: add random punctuation to generated word lists and update documentation to reflect this behavior#60johnny603 wants to merge 1 commit intolemnos:masterfrom
johnny603 wants to merge 1 commit intolemnos:masterfrom
Conversation
…entation to reflect this behavior
Open
|
I tried this and it adds punctuation to every word, which I don't think is natural: Maybe every 6 or so words would be better? Ideally it would be an option along with turning this feature on and off. Thanks! EDIT, this seems to work: // Only add punctuation if:
// - it's the 6th word in a group (i+1 % 6 == 0)
// - and NOT the last word overall
if (i+1)%6 == 0 && i != n-1 {
punct = punctuations[rand.Int()%len(punctuations)]
} |
|
I updated it with #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.