Add allow_pickle keyword to control pickle usage#52
Open
KennyChenBasis wants to merge 2 commits intolebedov:masterfrom
Open
Add allow_pickle keyword to control pickle usage#52KennyChenBasis wants to merge 2 commits intolebedov:masterfrom
KennyChenBasis wants to merge 2 commits intolebedov:masterfrom
Conversation
|
Hi @KennyChenBasis and @lebedov My big +1 here. Just found this package, very compactly written. My thought was to recommend this as a replacement for distributing data by pickles. Regarding defaults: I for sure expect that loading has pickles off, and prefer that saving has pickling turned off (but that's an opinion, just saving does not introduce vulnerability per se). |
|
This would be great to have in a pypi or conda-forge release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
I have kept the current defaults, though, again, we might want to change the defaults (if we were to change the defaults to match numpy's, a possible nice interface for
patchwould be to have it haveallow_pickle=Nonewhich would mean to not patchPacker,Unpacker, etc., so they'll all use their defaults forallow_pickle).