Release 2.4.1#369
Conversation
|
Published |
Bumps [c8](https://github.com/bcoe/c8) from 8.0.1 to 10.1.3. - [Release notes](https://github.com/bcoe/c8/releases) - [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md) - [Commits](bcoe/c8@v8.0.1...v10.1.3) --- updated-dependencies: - dependency-name: c8 dependency-version: 10.1.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 4.53.3 to 4.53.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.53.3...v4.53.5) --- updated-dependencies: - dependency-name: rollup dependency-version: 4.53.5 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
build(deps-dev): bump c8 from 8.0.1 to 10.1.3
…-4.53.5 build(deps-dev): bump rollup from 4.53.3 to 4.53.5
There was a problem hiding this comment.
Pull request overview
This is a patch release (2.4.1) following updates to rollup and its build plugins. The PR focuses on dependency updates and test fixes to address compatibility issues arising from the build system changes.
Key Changes:
- Upgraded c8 code coverage tool from ^8.0.0 to ^10.1.3
- Updated test logic to handle different test environments where
globalThis.navigatormay not exist - Modified language matching test to verify cross-format compatibility (hyphen vs underscore in locale codes)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/unit.tests.js | Adds conditional logic for stubbing navigator in different test environments and updates test case to verify language matching across different locale formats |
| package.json | Upgrades c8 dependency from ^8.0.0 to ^10.1.3 |
| package-lock.json | Updates dependency lockfile with c8 upgrade and related transitive dependencies including @bcoe/v8-coverage, test-exclude, foreground-child, and signal-exit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@rollup/plugin-commonjs": "^29.0.0", | ||
| "@rollup/plugin-terser": "^0.4.4", | ||
| "c8": "^8.0.0", | ||
| "c8": "^10.1.3", |
There was a problem hiding this comment.
The upgrade to c8 ^10.1.3 requires Node.js >=18, but the project's engines field specifies Node.js >= 14.x. This creates an incompatibility. Either downgrade c8 to a version that supports Node 14, or update the engines field in package.json to require Node.js >= 18. This is a breaking change that should be documented if proceeding with the upgrade.
There was a problem hiding this comment.
@copilot upgrade the engines field to node 18
|
@jankapunkt I've opened a new pull request, #374, to work on those changes. Once the pull request is ready, I'll request review from you. |
…eanup Co-authored-by: jankapunkt <1135285+jankapunkt@users.noreply.github.com>
Co-authored-by: jankapunkt <1135285+jankapunkt@users.noreply.github.com>
Replace invalid sinon.define with Object.defineProperty and cleanup
|
@jankapunkt I've opened a new pull request, #381, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: jankapunkt <1135285+jankapunkt@users.noreply.github.com>
chore: upgrade engines field to Node >= 18.x for c8 compatibility
Summary
This is simple patch release after updating rollup and some of its build plugins, which caused a different build output with seemingly improved performance and filesize.
Linked issue(s)
none
Involved parts of the project
tests, build system
Added tests?
some fixed
Webspeech API standard
none
Reproduction
none