Skip to content

[Merged by Bors] - feat(LinearAlgebra/QuadraticForm/TensorProduct): base change of quadratic forms#6636

Closed
eric-wieser wants to merge 9 commits into
masterfrom
eric-wieser/QuadraticForm.baseChange
Closed

[Merged by Bors] - feat(LinearAlgebra/QuadraticForm/TensorProduct): base change of quadratic forms#6636
eric-wieser wants to merge 9 commits into
masterfrom
eric-wieser/QuadraticForm.baseChange

Conversation

@eric-wieser

@eric-wieser eric-wieser commented Aug 17, 2023

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Aug 17, 2023
@eric-wieser eric-wieser changed the title feat(LinearAlgebra/QuadraticForm/TensorProduct): base change of bilinear forms feat(LinearAlgebra/QuadraticForm/TensorProduct): base change of quadratic forms Aug 17, 2023
@eric-wieser

Copy link
Copy Markdown
Member Author

I also tried to prove:

theorem _root_.BilinForm.toQuadraticForm_tmul (B₁ : BilinForm A M₁) (B₂ : BilinForm R M₂) :
    (B₁.tmul B₂).toQuadraticForm
      = B₁.toQuadraticForm.tmul B₂.toQuadraticForm := by
  letI : Invertible (2 : A) := (Invertible.map (algebraMap R A) 2).copy 2 (map_ofNat _ _).symm
  rw [QuadraticForm.tmul, tensorDistrib, BilinForm.tmul]
  dsimp
  refine (associated_rightInverse R).injective ?_
  refine BilinForm.toLin.injective ?_
  ext a₁ a₂ b₁ b₂
  dsimp [-associated_apply]
  simp [sub_smul, smul_sub, add_smul, smul_add, ←smul_mul_smul]
  set aa₁ := B₁ a₁ a₁
  set ab₁ := B₁ a₁ b₁
  set ba₁ := B₁ b₁ a₁
  set bb₁ := B₁ b₁ b₁
  set aa₂ := B₂ a₂ a₂
  set ab₂ := B₂ a₂ b₂
  set ba₂ := B₂ b₂ a₂
  set bb₂ := B₂ b₂ b₂
  sorry

though the algebra is too painful to get to a point where it's obvious whether it's true.

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 17, 2023
@ghost

ghost commented Aug 17, 2023

Copy link
Copy Markdown

Comment thread Mathlib/LinearAlgebra/QuadraticForm/TensorProduct.lean
Comment thread Mathlib/LinearAlgebra/QuadraticForm/TensorProduct.lean Outdated
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
@eric-wieser eric-wieser requested a review from alexjbest August 21, 2023 22:28
@alexjbest

Copy link
Copy Markdown
Member

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by alexjbest.

@ocfnash ocfnash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Comment thread Mathlib/LinearAlgebra/QuadraticForm/TensorProduct.lean
@bors

bors Bot commented Aug 25, 2023

Copy link
Copy Markdown

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Aug 25, 2023
@eric-wieser

Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions Bot added the ready-to-merge This PR has been sent to bors. label Aug 25, 2023
bors Bot pushed a commit that referenced this pull request Aug 25, 2023
@bors

bors Bot commented Aug 25, 2023

Copy link
Copy Markdown

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors Bot changed the title feat(LinearAlgebra/QuadraticForm/TensorProduct): base change of quadratic forms [Merged by Bors] - feat(LinearAlgebra/QuadraticForm/TensorProduct): base change of quadratic forms Aug 25, 2023
@bors bors Bot closed this Aug 25, 2023
@bors bors Bot deleted the eric-wieser/QuadraticForm.baseChange branch August 25, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants