Skip to content

chore(MathlibTest): fix defLemma warnings#40593

Open
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:deflemma-tests
Open

chore(MathlibTest): fix defLemma warnings#40593
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:deflemma-tests

Conversation

@grunweg

@grunweg grunweg commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

In all these cases, a dummy definition was declared of type True. This triggered the defLemma linter (and will trigger the defProp linter in Lean core). Fix the warnings by using the natural number 0 instead.


Open in Gitpod

In all these cases, a dummy definition was declared of type True.
This triggered the defLemma linter (and will trigger the defProp linter
in Lean core). Fix the warnings by using the natural number 0 instead.
@grunweg grunweg requested a review from kim-em June 14, 2026 08:42
@grunweg grunweg added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jun 14, 2026
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

PR summary 916161bff7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 916161b).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 916161bff7
Reference commit 4ab45e92be

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant