Skip to content

[Merged by Bors] - chore(Counterexamples/DirectSumIsInternal): fix defLemma error#40592

Closed
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:fix-deflemma
Closed

[Merged by Bors] - chore(Counterexamples/DirectSumIsInternal): fix defLemma error#40592
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:fix-deflemma

Conversation

@grunweg

@grunweg grunweg commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

As could be seen from running #lint in that file.
The new defProp linter in Lean core also flagged this.


Open in Gitpod

As could be seen from running #lint in that file.
The new defProp lint in Lean core also flagged this.
@grunweg grunweg requested a review from kim-em June 14, 2026 08:35
@grunweg grunweg added easy < 20s of review time. See the lifecycle page for guidelines. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jun 14, 2026
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

PR summary 99f934225f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 99f9342).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 99f934225f
Reference commit 4ab45e92be

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Jun 15, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 15, 2026
As could be seen from running #lint in that file.
The new `defProp` linter in Lean core also flagged this.
@mathlib-bors

mathlib-bors Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Counterexamples/DirectSumIsInternal): fix defLemma error [Merged by Bors] - chore(Counterexamples/DirectSumIsInternal): fix defLemma error Jun 15, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants