Skip to content

feat(Topology/Algebra): inv and div for infinite products over groups with zero#40591

Open
ajirving wants to merge 4 commits into
leanprover-community:masterfrom
ajirving:hasprod_inv0
Open

feat(Topology/Algebra): inv and div for infinite products over groups with zero#40591
ajirving wants to merge 4 commits into
leanprover-community:masterfrom
ajirving:hasprod_inv0

Conversation

@ajirving

Copy link
Copy Markdown
Contributor

Proves two lemmas for infinite products over groups with zero: inverses and division behave as expected provided the limit is nonzero. This requires an extra import to get some of the GroupWithZero API. Maybe the GroupWithZero results should be in a different file but I was just adding to what was already there in Group.lean.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

PR summary cf8b53ebcc

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.Algebra.InfiniteSum.Group 1136 1137 +1 (+0.09%)
Import changes for all files
Files Import difference
6 files Mathlib.Topology.Algebra.InfiniteSum.Constructions Mathlib.Topology.Algebra.InfiniteSum.DiscreteConvolution Mathlib.Topology.Algebra.InfiniteSum.GroupCompletion Mathlib.Topology.Algebra.InfiniteSum.Group Mathlib.Topology.Algebra.InfiniteSum.Module Mathlib.Topology.Algebra.InfiniteSum.NatInt
1

Declarations diff (regex)

+ HasProd.div₀
+ HasProd.inv₀

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit cf8b53e).

  • +2 new declarations
  • −0 removed declarations
+HasProd.div₀
+HasProd.inv₀

No changes to strong technical debt.

No changes to weak technical debt.

Current commit cf8b53ebcc
Reference commit 0c9776382e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jun 14, 2026
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@ajirving ajirving changed the title feat(Topology.Algebra): inv and div for infinite products over groups with zero feat(Topology/Algebra): inv and div for infinite products over groups with zero Jun 14, 2026
Comment thread Mathlib/Topology/Algebra/InfiniteSum/Group.lean Outdated
@plp127

plp127 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Can you generalize these lemmas to an arbitrary SummationFilter, instead of just .unconditional?

ajirving and others added 2 commits June 14, 2026 15:27
Co-authored-by: Aaron Liu <aaronliu2008@outlook.com>
@ajirving

ajirving commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

Can you generalize these lemmas to an arbitrary SummationFilter, instead of just .unconditional?

Thanks, I've done that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants