Skip to content

feat(RingTheory/AdjoinRoot): more on `AdjoinRoot' of monic polynomials#40590

Open
BryceT233 wants to merge 2 commits into
leanprover-community:masterfrom
BryceT233:adjoinroot_monic
Open

feat(RingTheory/AdjoinRoot): more on `AdjoinRoot' of monic polynomials#40590
BryceT233 wants to merge 2 commits into
leanprover-community:masterfrom
BryceT233:adjoinroot_monic

Conversation

@BryceT233

Copy link
Copy Markdown
Contributor

This PR adds some missing basic API for AdjoinRoot p where p is a monic polynomial.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

PR summary 4448dff6f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ faithfulSMul_of_monic_of_degree_pos
+ isIntegral_of_monic
+ isLocalHom_of_monic_of_degree_pos
+ nontrivial_iff_of_monic
+ of.injective_of_monic_of_degree_pos

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 4448dff).

  • +5 new declarations
  • −0 removed declarations
+AdjoinRoot.faithfulSMul_of_monic_of_degree_pos
+AdjoinRoot.isIntegral_of_monic
+AdjoinRoot.isLocalHom_of_monic_of_degree_pos
+AdjoinRoot.nontrivial_iff_of_monic
+AdjoinRoot.of.injective_of_monic_of_degree_pos

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 4448dff6f1
Reference commit e59d9d4058

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant