fix(mcp,core): #3504 silent npx exit + dead URL hints + score contracts#15
Merged
fix(mcp,core): #3504 silent npx exit + dead URL hints + score contracts#15
Conversation
…e contracts Three failure modes a user hits before they get any work done, fixed in one pass. 1. #3504 — `npx -y @leadbay/mcp` silently exits 0 on Node 25. The `isEntrypoint` check compared `process.argv[1]` (the npx shim symlink) to `import.meta.url` (the resolved `dist/bin.js`); they never match, so `main()` never runs and the MCP host sees a dead connection with no diagnostic. Both sides now go through `realpathSync` so the symlink collapses. Reproduce-then-fix verified with a new `test/smoke/npx-entrypoint.test.ts` regression guard. 2. Dead `app.leadbay.ai` URLs in error strings and READMEs replaced with the real recovery commands (`leadbay-mcp install`, `leadbay-mcp login`). Hints now include `--region <us|fr>` because the CLI refuses without it (anti- cross-region credential-leak guard) — earlier draft would have dead-ended the user a second time. 3. `avg_score_0_to_10` on `pull_leads` / `bulk_qualify_leads` was lying: per- question AI agent scores are discrete boosts (-10/0/10/20), not 0-10 averages. Renamed to `avg_qualification_boost` with JSDoc on the underlying `AiAgentResponse.score` interface explaining the real contract. Documented `score` (ICP similarity) vs `ai_agent_lead_score` (deep-AI qualification boost) — they're combined and normalized server-side to 0-100. Live smoke harness extended with composite-level checks + optional thinking- model judge that writes a redacted report to `.context/`. Token-first via `LEADBAY_TEST_TOKEN`; macOS Keychain fallback (refuses plaintext password env var, on purpose). Versions: core 0.2.0→0.2.1 (private), leadclaw + mcp 0.2.1→0.2.2 (openclaw plugin manifest synced). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Both branches independently bumped mcp/leadclaw to 0.2.2. Combined into a single 0.2.2 release: this branch's npx silent-exit fix + dead URL hints + score-contract correction PLUS main's mental-model docs (SERVER_INSTRUCTIONS inbox/two-scoring-layers/daily-rhythm + per-tool description rewrites + the new openclaw.plugin.json description). Single coherent release rather than two near-simultaneous tags. Conflicts resolved: - packages/leadclaw/CHANGELOG.md: merged 0.2.2 entries. - packages/leadclaw/openclaw.plugin.json: kept main's longer description. - packages/mcp/CHANGELOG.md: merged 0.2.2 entries. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three failure modes a user hits before getting any work done, fixed in one pass:
npx -y @leadbay/mcpexited 0 silently on Node 25 becauseisEntrypointcompared the npx shim symlink to the resolveddist/bin.js. Both sides now go throughrealpathSync. Newtest/smoke/npx-entrypoint.test.tsis the regression guard (reproduce-then-fix verified).app.leadbay.aiURLs in error strings + READMEs with the real recovery commands. Hints now include--region <us\|fr>because the CLI refuses without it (anti-cross-region credential-leak guard).avg_score_0_to_10was lying — per-question AI agent scores are discrete boosts (-10/0/10/20). Renamed toavg_qualification_boost. JSDoc onAiAgentResponse.score,LeadPayload.score, andLeadPayload.ai_agent_lead_scorenow documents the real contract (similarity + qualification boost, combined and normalized server-side to 0-100).Live smoke harness extended with composite-level checks + optional thinking-model judge writing a redacted report to
.context/. Token-first viaLEADBAY_TEST_TOKEN; macOS Keychain fallback (refuses plaintext password env var). Versions: core 0.2.0→0.2.1 (private), leadclaw + mcp 0.2.1→0.2.2 (openclaw plugin manifest synced).Test plan
pnpm -r typecheckgreen across core / leadclaw / mcppnpm test— unit suite passespnpm --filter @leadbay/mcp test:smoke—npx-entrypoint.test.tspasses;live.test.tspasses against real account (LEADBAY_TEST_TOKEN + ANTHROPIC_API_KEY)npx --helptranscript🤖 Generated with Claude Code