fix(ci): accept docformatter exit code 3 in publish.sh#1
Merged
Conversation
docformatter 1.7.8 with in-place=true exits 3 when it reformats files, which the generic run_command wrapper treated as failure and aborted step 8/24. Inline the docformatter step so exit codes 0 and 3 are both treated as success. Also gitignore .ken (kenboard CLI config with API token). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docformatter1.7.8 within-place = trueexits 3 when it reformats files; previous versions exited 0. The genericrun_commandwrapper inpublish.shtreats any non-zero exit as failure, so step 8/24 (Docstring Formatting) aborts the publish workflow — see run 25668514928.publish.shso exit codes 0 and 3 are both treated as success. All other lint/format steps continue to userun_commandunchanged..ken(kenboard CLI config; contains an API token).Test plan
pdm run docformatteron unformatted tree → exit 3, files reformatted in-place, patched wrapper reports successpdm run docformatteron already-formatted tree → exit 0, patched wrapper reports successPublish Packagerun completes step 8/24🤖 Generated with Claude Code