Conversation
This PR has the docs to define the benchmarking framework. please see benchmarks/README.md for more information. It still requires significant cleanup but things are working. Overtime the full docker hermetic configuration will make it into benchmarks/flake.nix and things will get more stable.
| │ │ ├── small.sh # Defines a shell script for running -- use IN_ASTERINAS env var | ||
| │ │ └── big.sh |
There was a problem hiding this comment.
we might want to use a similar structure to asterinas where we have host and run sh in a folder or something
arthurp
left a comment
arthurp
left a comment
There was a problem hiding this comment.
Some initial comments. Once I have a slightly better understanding, I will try to setup filebench using this.
- I don't see how to actually run the nix based benchmarks.
| memcached-src = { | ||
| url = "https://memcached.org/files/memcached-1.6.32.tar.gz"; # version: 1.6.32 | ||
| flake = false; | ||
| }; | ||
|
|
||
| libmemcached-src = { | ||
| url = "https://launchpad.net/libmemcached/1.0/1.0.18/+download/libmemcached-1.0.18.tar.gz"; # version: 1.0.18 | ||
| flake = false; | ||
| }; |
There was a problem hiding this comment.
Why is this duplicated here and in the parent nix file? (I don't know enough about nix to know if this is normal and why it might be done.)
| │ │ ├── small.sh # Defines a shell script for running -- use IN_ASTERINAS env var | ||
| │ │ └── big.sh | ||
| │ └── p90 # folder defines a trackable metric | ||
| │ └── filter.awk # awk filter script |
There was a problem hiding this comment.
Let's not use awk. I know it's actually pretty good for this. But most people don't know it (including me). We probably actually want to use Python that can eventually be loaded as a module which generates dataframes if needed. Using python also means we can easily have all the metrics in one loader file which only processes the input file once and allows easy sharing of the parser or processing code.
| @cp -r /usr/local/memcached $@ | ||
| @mkdir -p $@/memcached/bin | ||
| @cp -L $$(which memcached) $@/memcached/bin/memcached |
There was a problem hiding this comment.
Why the change of location? And how does this pick up the nix based build? Or does it?
2 participants
This PR has the docs to define the benchmarking framework. please see benchmarks/README.md for more information.
It still requires significant cleanup but things are working. Overtime the full docker hermetic configuration will make it into benchmarks/flake.nix and things will get more stable.