Quick ARM64 compatibility fix: remove amd64, bypass Makefile pull#130
Open
dhruvgoyalsjc wants to merge 1 commit intoldos-project:mainfrom
Open
Quick ARM64 compatibility fix: remove amd64, bypass Makefile pull#130dhruvgoyalsjc wants to merge 1 commit intoldos-project:mainfrom
dhruvgoyalsjc wants to merge 1 commit intoldos-project:mainfrom
Conversation
Author
|
Related to #131 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a quick workaround to allow building the KernMLOps Docker image on ARM64 machines (e.g. Apple Macs with M4 chip).
Changes
docker pullline in the Makefile near line 196 to avoid pulling x86-only imageamd64witharm64in Dockerfile.devNotes
This fix is hardcoded for arm64 and not yet generic. Submitted per @tewaro's instructions.