Fix intermediate integer overflow in math.perm and math.comb#2879
Open
ekMartian wants to merge 1 commit intolcompilers:mainfrom
Open
Fix intermediate integer overflow in math.perm and math.comb#2879ekMartian wants to merge 1 commit intolcompilers:mainfrom
ekMartian wants to merge 1 commit intolcompilers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous implementations calculated the full
factorial(n)before division. This caused an intermediate integer overflow for valid 32-bit/64-bit inputs. For example,perm(30, 1)correctly evaluates to30, but calculating30!first exceeds the 64-bit integer limit and returns garbage.Changes
comb(k = n - kifk > n/2).k_final) to prevent parameter immutability compiler errors.Verification
Verified locally that
perm(30, 1)andcomb(30, 1)now correctly return30instead of overflowing to negative values.