Make tests faster by avoiding unnecessary waiting#79
Open
cwalther wants to merge 2 commits intolbovet:masterfrom
Open
Make tests faster by avoiding unnecessary waiting#79cwalther wants to merge 2 commits intolbovet:masterfrom
cwalther wants to merge 2 commits intolbovet:masterfrom
Conversation
Running jest runs the two test suites in parallel. If both try to run a server on port 3000, only one of them will succeed and supply files for both, however when that suite finishes first, it will take down the server and leave the other one hanging. Fix this by running the servers on different ports.
Puppeteer allows us to wait for the specific element we want to check instead of waiting for a fixed time and hoping it will be there by then. This reduces the total testing time from 26s to 7s for me.
Collaborator
No wise hidden motives there. If I recall correctly, I was trying different end-to-end testing frameworks (first Nightwatch, then the jest + puppeter combo), and didn't get around to optimize the tests. This speedup by a factor of 9 is... very welcome. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I suspected yesterday, it seems like the tests can actually be sped up massively by avoiding hardcoded wait times: Puppeteer allows us to wait for the specific element we want to check instead of waiting for a fixed time and hoping it will be there by then. I’m not sure if there was a reason for doing it this way, but replacing the waits seems to work well for me.
This reduces the total testing time from 26s to 7s for me.
The commit is stacked on #78 because only that allowed me to get meaningful figures, but is independent and could be rebased if desired for a neater branching layout.