Add Zipline Backtesting Environment with ClassicModel Integration#54
Add Zipline Backtesting Environment with ClassicModel Integration#54laurentvv wants to merge 2 commits into
Conversation
Co-authored-by: laurentvv <8775515+laurentvv@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
| true_range = ranges.max(axis=1) | ||
| df["ATR_14"] = true_range.rolling(14).mean() | ||
|
|
||
| df.fillna(method="bfill", inplace=True) |
There was a problem hiding this comment.
CRITICAL: Deprecated pandas fillna(method=...) syntax
The fillna(method="bfill", inplace=True) syntax was deprecated in pandas 2.0 and removed in pandas 3.0. Since the project uses pandas 2.2.3, this should use df.bfill(inplace=True) instead.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previous CRITICAL issue about deprecated pandas No new issues found in the incremental changes (whitespace fixes and new file additions only). Files Reviewed (11 files)
Reviewed by laguna-m.1-20260312:free · 139,456 tokens |
Co-authored-by: laurentvv <8775515+laurentvv@users.noreply.github.com>
This branch introduces a complete algorithmic backtesting pipeline using
zipline-reloaded.Features included:
backtests/fetch_data.py): Fetches historical data from Yahoo Finance and formats it as a custom Zipline bundle (csvdir_equities).backtests/filter_csv.py): Resolves specific data anomalies required by Zipline (like missing dates causing misalignment or capping the WTI negative prices of April 2020 which break Zipline's uint32 casting).backtests/run_zipline_backtest.py):ClassicModelon pre-backtest windows.*_backtest.png).PR created automatically by Jules for task 1715705710406165164 started by @laurentvv