Fix two dead-code paths (slowapi_startup, callable scope on shared_limit)#270
Open
khreechari wants to merge 2 commits into
Open
Fix two dead-code paths (slowapi_startup, callable scope on shared_limit)#270khreechari wants to merge 2 commits into
khreechari wants to merge 2 commits into
Conversation
khreechari
commented
Apr 24, 2026
khreechari
commented
This method referenced an undefined `app` variable (NameError on call) and was masked from mypy with # type: ignore. It has no callers anywhere in the codebase, docs, or tests — it never worked and never ran. Flagged by ruff F821 (undefined name) and vulture (unused method).
The Limit.scope property referenced an undefined `request` variable when the scope was callable (wrappers.py:62), so any shared_limit() with a callable scope would NameError on first invocation. The feature was documented but never worked, and no test covered it. Replace the property with scope_for(request: Request) and pass the request through to the callable — matching how key_func receives the request. Update the one caller in extension.py. Add a regression test exercising callable scope: two routes sharing the limit, with the scope keyed off a request header, verifying that different header values get independent buckets and that shared values exhaust across both routes. Flagged by ruff F821 (undefined name `request`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.