Merged
Conversation
✅ Deploy Preview for lando-drupal ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Known-failing mod_expires test will break CI
- Removed the mod_expires test from README.md that would fail when the module is not loaded in Apache config, preventing CI failures.
Or push these changes by commenting:
@cursor push 22c636c773
Preview (22c636c773)
diff --git a/examples/drupal-defaults/README.md b/examples/drupal-defaults/README.md
--- a/examples/drupal-defaults/README.md
+++ b/examples/drupal-defaults/README.md
@@ -47,9 +47,6 @@
# Should have mod_headers enabled and working
lando exec appserver -- curl -sI localhost | grep -i "X-Lando-Test: blazes"
-# Should have mod_expires enabled and working
-lando exec appserver -- curl -sI localhost | grep -i "Expires:"
-
# Should use the correct default config files
lando exec appserver -- cat /usr/local/etc/php/conf.d/zzz-lando-my-custom.ini | grep "; LANDODRUPALPHPINI"
lando exec appserver -- curl -L http://localhost/info.php | grep max_execution_time | grep 91
Adds .htaccess to drupal-defaults example that sets a custom header via mod_headers and enables mod_expires. Adds verification commands to check for these in curl responses. These tests validate that Apache modules commonly needed by Drupal (mod_headers for CORS/security headers, mod_expires for caching) work out of the box. Refs: lando/lando#976, lando/apache#2
- Enabled mod_headers and mod_expires Apache modules by default - Fixed xdebug log ownership issue with build_as_root/run_as_root
AaronFeledy
force-pushed
the
test/mod-headers-expires
branch
from
13119e4 to
b6e9499
Compare
AaronFeledy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@lando/phpto^1.12.0What's in @lando/php v1.12.0
The test in this PR verifies that mod_headers and mod_expires are now available by default.
Note
Medium Risk
Updates the underlying
@lando/phpruntime, which can change default Apache/PHP behavior (now enablingmod_headers/mod_expires) and may affect existing Drupal apps. Test coverage is updated, but runtime dependency bumps can still introduce subtle compatibility issues.Overview
Updates the plugin’s PHP service dependency to
@lando/php@^1.12.0(and lockfile), aligning with upstream changes including default Apache module enablement and an Xdebug log ownership fix.Extends the
examples/drupal-defaultsverification suite by adding a.htaccessand checks thatmod_headersandmod_expiresare enabled and functional, and notes the upgrade in theCHANGELOG.Written by Cursor Bugbot for commit 5479128. This will update automatically on new commits. Configure here.