Skip to content

Add w3_validate_<type name> functions #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartinSStewart wants to merge 6 commits into
base: lamdera-next
Choose a base branch
from
Open

Add w3_validate_<type name> functions #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45b8393
Add w3_validate_<Type> validation hook for generated custom-type deco…
claude May 27, 2026
e273288
Add recursive-type tests for the w3_validate decoder hook
claude May 27, 2026
57ef9ae
Add runtime test for w3_validate decode rejection
claude May 27, 2026
a74c495
Expand w3_validate test coverage
claude May 28, 2026
4dc2e55
Detect validator + generated-wire-fn references with a clear compile …
claude Jun 2, 2026
f9487f0
Add non-validating w3_unsafe_decode_<T> alongside validating w3_decod…
claude Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extra/Lamdera/CLI/Backend.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ addBackendModelDecl base64 =
\ >> nextChunk []\n\
\ )\n\
\ |>Lamdera.Wire3.intListToBytes\n\
\ |>Lamdera.Wire3.bytesDecode Types.w3_decode_BackendModel\n\
\ |>Lamdera.Wire3.bytesDecode Types.w3_unsafe_decode_BackendModel\n\
\ |>(\\maybeModel ->\n\
\ case maybeModel of\n\
\ Just m -> m\n\
Expand Down
22 changes: 11 additions & 11 deletions extra/Lamdera/Evergreen/MigrationHarness.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,14 @@ decodeAndUpgradeFor migrationSequence nextVersion valueType = do
if valueType == "BackendModel" then
[text|
$nextVersion_ ->
decodeType $valueTypeInt version bytes T$nextVersion_.w3_decode_$valueType
decodeType $valueTypeInt version bytes T$nextVersion_.w3_unsafe_decode_$valueType
|> upgradeIsCurrent
|> otherwiseError
|]
else
[text|
$nextVersion_ ->
decodeType $valueTypeInt version bytes T$nextVersion_.w3_decode_$valueType
decodeType $valueTypeInt version bytes T$nextVersion_.w3_unsafe_decode_$valueType
|> upgradeIsCurrent
|> otherwiseError
|]
Expand Down Expand Up @@ -308,13 +308,13 @@ migrationForType migrationSequence migrationsForVersion startVersion finalVersio
if tipe == "BackendModel"
then
[text|
decodeType $valueTypeInt $finalVersion_ bytes T$finalVersion_.w3_decode_$tipe
decodeType $valueTypeInt $finalVersion_ bytes T$finalVersion_.w3_unsafe_decode_$tipe
|> upgradeSucceeds
|> otherwiseError
|]
else
[text|
decodeType $valueTypeInt $finalVersion_ bytes T$finalVersion_.w3_decode_$tipe
decodeType $valueTypeInt $finalVersion_ bytes T$finalVersion_.w3_unsafe_decode_$tipe
|> upgradeSucceeds
|> otherwiseError
|]
Expand All @@ -323,14 +323,14 @@ migrationForType migrationSequence migrationsForVersion startVersion finalVersio
if tipe == "BackendModel"
then
[text|
decodeType $valueTypeInt $startVersion_ bytes T$startVersion_.w3_decode_$tipe
decodeType $valueTypeInt $startVersion_ bytes T$startVersion_.w3_unsafe_decode_$tipe
$intermediateMigrationsFormatted
|> upgradeSucceeds
|> otherwiseError
|]
else
[text|
decodeType $valueTypeInt $startVersion_ bytes T$startVersion_.w3_decode_$tipe
decodeType $valueTypeInt $startVersion_ bytes T$startVersion_.w3_unsafe_decode_$tipe
$intermediateMigrationsFormatted
|> upgradeSucceeds
|> otherwiseError
Expand Down Expand Up @@ -397,16 +397,16 @@ intermediateMigration allMigrations tipe from to finalVersion =
migrationFn = [text|M$to_.$typenameCamel|]
in
[text|
|> $thenMigrateForType $valueTypeInt $migrationFn T$from_.w3_encode_$tipe T$to_.w3_decode_$tipe $to_
|> $thenMigrateForType $valueTypeInt $migrationFn T$from_.w3_encode_$tipe T$to_.w3_unsafe_decode_$tipe $to_
|]

WithoutMigrations v ->
{- It might seem like this is uneeded, but it's for when there's a migration in our chain, yet
the last version has no migrations. I.e.:

decodeType "BackendModel" 1 intList T1.w3_decode_BackendModel
|> thenMigrateModel "BackendModel" M2.backendModel T1.w3_encode_BackendModel T2.w3_decode_BackendModel 2
|> thenMigrateModel "BackendModel" (always ModelUnchanged) T2.w3_encode_BackendModel T3.w3_decode_BackendModel 3
decodeType "BackendModel" 1 intList T1.w3_unsafe_decode_BackendModel
|> thenMigrateModel "BackendModel" M2.backendModel T1.w3_encode_BackendModel T2.w3_unsafe_decode_BackendModel 2
|> thenMigrateModel "BackendModel" (always ModelUnchanged) T2.w3_encode_BackendModel T3.w3_unsafe_decode_BackendModel 3
|> upgradeSucceeds CurrentBackendModel
|> otherwiseError

Expand All @@ -416,7 +416,7 @@ intermediateMigration allMigrations tipe from to finalVersion =
migrationFn = "(always " <> kindForType <> "Unchanged)"
in
[text|
|> $thenMigrateForType $valueTypeInt $migrationFn T$from_.w3_encode_$tipe T$to_.w3_decode_$tipe $to_
|> $thenMigrateForType $valueTypeInt $migrationFn T$from_.w3_encode_$tipe T$to_.w3_unsafe_decode_$tipe $to_
|]


Expand Down
Loading
Loading