Skip to content

Fix Duplicate(Alias|Union)Arg error message #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pithub wants to merge 1 commit into
base: lamdera-next
Choose a base branch
from
Open

Fix Duplicate(Alias|Union)Arg error message #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/src/Canonicalize/Environment/Local.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,13 @@ getEdges edges (A.At _ tipe) =
checkUnionFreeVars :: A.Located Src.Union -> Result i w Int
checkUnionFreeVars (A.At unionRegion (Src.Union (A.At _ name) args ctors)) =
let
addArg (A.At region arg) dict =
addArg dict (A.At region arg) =
Dups.insert arg region region dict

addCtorFreeVars (_, tipes) freeVars =
List.foldl' addFreeVars freeVars tipes
in
do boundVars <- Dups.detect (Error.DuplicateUnionArg name) (foldr addArg Dups.none args)
do boundVars <- Dups.detect (Error.DuplicateUnionArg name) (List.foldl' addArg Dups.none args)
let freeVars = foldr addCtorFreeVars Map.empty ctors
case Map.toList (Map.difference freeVars boundVars) of
[] ->
Expand All @@ -207,10 +207,10 @@ checkUnionFreeVars (A.At unionRegion (Src.Union (A.At _ name) args ctors)) =
checkAliasFreeVars :: A.Located Src.Alias -> Result i w [Name.Name]
checkAliasFreeVars (A.At aliasRegion (Src.Alias (A.At _ name) args tipe)) =
let
addArg (A.At region arg) dict =
addArg dict (A.At region arg) =
Dups.insert arg region region dict
in
do boundVars <- Dups.detect (Error.DuplicateAliasArg name) (foldr addArg Dups.none args)
do boundVars <- Dups.detect (Error.DuplicateAliasArg name) (List.foldl' addArg Dups.none args)
let freeVars = addFreeVars Map.empty tipe
let overlap = Map.size (Map.intersection boundVars freeVars)
if Map.size boundVars == overlap && Map.size freeVars == overlap
Expand Down
Loading