Skip to content

[scanner] fix: align Storybook stack to 10.4.6 and remove legacy test imports#19163

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/scanner-fix-update-dependencies-with-available-maj
Closed

[scanner] fix: align Storybook stack to 10.4.6 and remove legacy test imports#19163
Copilot wants to merge 2 commits into
mainfrom
copilot/scanner-fix-update-dependencies-with-available-maj

Conversation

Copilot AI commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Adding or modifying a card/dashboard? Read the Card Development Guide first — it covers required patterns, common pitfalls, and the full file checklist.

New CNCF project card? New cards go in kubestellar/console-marketplace, not this repo. PRs adding new cards here will be redirected.

Use a coding agent. This repo is primarily developed with Claude Code (Opus 4.5/4.6). It knows all codebase patterns (isDemoData, useCardLoadingState, locale strings, DCO). Manual PRs that miss required patterns will be sent back.

📌 Fixes


📝 Summary of Changes

Storybook had a major-version drift (8.6.18 vs available 10.4.6) flagged by Auto-QA. This update moves the Storybook toolchain to 10.4.6 and applies the required package-import migration to stay compatible with 9.x/10.x package consolidation.

  • Dependency alignment
    • Bumped storybook to ^10.4.6
    • Bumped @storybook/react, @storybook/react-vite, and @storybook/addon-a11y to ^10.4.6
  • 9.x/10.x migration compatibility
    • Replaced deprecated @storybook/test imports with storybook/test in story files
  • Breaking-change audit (9.x + 10.x)
    • Verified current .storybook config is already ESM-compatible
    • No additional config/API refactor was required for this repo’s current Storybook usage
// before
import { fn } from '@storybook/test'

// after
import { fn } from 'storybook/test'

Changes Made

  • Updated Storybook dependencies in web/package.json to ^10.4.6
  • Refactored Story imports from @storybook/test to storybook/test
  • Fixed version skew between storybook core and @storybook/* packages
  • Added tests for this change (not applicable; dependency/import migration only)

Checklist

Please ensure the following before submitting your PR:

  • I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
  • I have reviewed the project's contribution guidelines
  • New cards target console-marketplace, not this repo
  • isDemoData is wired correctly (cards show Demo badge when using demo data)
  • I have written unit tests for the changes (if applicable)
  • I have tested the changes locally and ensured they work as expected
  • All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A (dependency and Storybook import-path update only).


👀 Reviewer Notes

  • This PR intentionally avoids lockfile regeneration and local install; dependency resolution is deferred to CI as requested.
  • If CI surfaces environment constraints for Storybook 10 (e.g., Node runtime floor), that should be handled in CI/runtime config, not in this dependency-only PR.
Original prompt

Fix issue #19161 by updating Storybook from version 8.6.18 to 10.4.6.

The Auto-QA security scanner has detected that Storybook has a major version update available (8.6.18 → 10.4.6).

Required changes:

  1. Update web/package.json to change storybook from "^8.6.18" to "^10.4.6"
  2. Update all @storybook/* dependencies to match version 10.4.6
  3. Check for any breaking changes in the Storybook 9.x and 10.x migration guides
  4. Update any imports or API usage if breaking changes exist
  5. Do NOT run npm install locally - CI will handle that

Important notes:

  • This is a major version update (8 → 10) so there may be breaking changes
  • Review the Storybook changelog for versions 9.x and 10.x before updating
  • If significant breaking changes require code refactoring, document them in the PR
  • The PR must follow the commit convention: "[scanner] fix: update dependencies with available major version bumps" with DCO sign-off

The PR body should start with "Fixes #19161" on the first line to auto-close the issue when merged.

@kubestellar-prow kubestellar-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 19, 2026
@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole failed. Why did it fail? →

Name Link
🔨 Latest commit 4825cf4
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a34b00e797b8d00089cd961

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @Copilot — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 19, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Auto Test Generator

The following new files have no corresponding test file:

  • web/src/components/ui/Button.stories.tsx
  • web/src/components/ui/FeatureHintTooltip.stories.tsx
  • web/src/components/ui/Pagination.stories.tsx
  • web/src/components/ui/RefreshIndicator.stories.tsx

Please add tests or apply the needs-tests label to track this PR.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

Copilot AI changed the title [WIP] [scanner] fix: update dependencies with available major version bumps [scanner] fix: align Storybook stack to 10.4.6 and remove legacy test imports Jun 19, 2026
Copilot AI requested a review from clubanderson June 19, 2026 02:58
@clubanderson clubanderson deleted the copilot/scanner-fix-update-dependencies-with-available-maj branch June 19, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: no Indicates the PR's author has not signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Auto-QA] Dependencies with major version updates available

2 participants