Skip to content

Extract GitOps SSE handlers into dedicated stream module#19148

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/extract-sse-streams
Closed

Extract GitOps SSE handlers into dedicated stream module#19148
Copilot wants to merge 3 commits into
mainfrom
copilot/extract-sse-streams

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Adding or modifying a card/dashboard? Read the Card Development Guide first — it covers required patterns, common pitfalls, and the full file checklist.

New CNCF project card? New cards go in kubestellar/console-marketplace, not this repo. PRs adding new cards here will be redirected.

Use a coding agent. This repo is primarily developed with Claude Code (Opus 4.5/4.6). It knows all codebase patterns (isDemoData, useCardLoadingState, locale strings, DCO). Manual PRs that miss required patterns will be sent back.

📌 Fixes

Issue linking is handled automatically by the system.


📝 Summary of Changes

SSE endpoint control flow for GitOps operators/subscriptions/helm releases was co-located with list/query code in operators.go, increasing file coupling. This PR isolates stream-specific behavior into a focused stream file while preserving endpoint behavior and signatures.

  • SSE extraction

    • Moved StreamOperators, StreamOperatorSubscriptions, and StreamHelmReleases out of pkg/api/handlers/gitops/operators.go
    • Added pkg/api/handlers/gitops/gitops_operator_streams.go as the stream-focused home for SSE handlers
  • Stream helper co-location

    • Moved stream-only demo helpers:
      • getDemoOperatorsForStreaming
      • getDemoHelmReleasesForStreaming
    • Kept stream loop/concurrency/control flow with the stream endpoints that use it
  • Separation of concerns

    • operators.go now retains list/query/fetch/cache logic
    • Stream transport concerns are isolated in the dedicated stream module
// now in pkg/api/handlers/gitops/gitops_operator_streams.go
func (h *GitOpsHandlers) StreamOperatorSubscriptions(c *fiber.Ctx) error { ... }
func (h *GitOpsHandlers) StreamHelmReleases(c *fiber.Ctx) error { ... }

Changes Made

  • Updated GitOps handler file organization to separate SSE transport paths from list/query paths
  • Refactored stream endpoints and stream-only helpers into gitops_operator_streams.go
  • Fixed architectural coupling called out in the issue by isolating stream control flow
  • Added tests for stream extraction (no behavior changes; existing coverage retained)

Checklist

Please ensure the following before submitting your PR:

  • I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
  • I have reviewed the project's contribution guidelines
  • New cards target console-marketplace, not this repo
  • isDemoData is wired correctly (cards show Demo badge when using demo data)
  • I have written unit tests for the changes (if applicable)
  • I have tested the changes locally and ensured they work as expected
  • All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A (backend handler refactor only)


👀 Reviewer Notes

Please review for architectural separation only: stream endpoint behavior, event shapes, and handler signatures are intended to remain unchanged.

@kubestellar-prow kubestellar-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 18, 2026
@netlify

netlify Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 1312c54
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a3454bd4b289b0008d25594

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2026
@github-actions github-actions Bot added tier/2-standard ai-generated Pull request generated by AI labels Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @Copilot — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 53ad3f0 Initial plan
  • 1312c54 🐛 Extract GitOps SSE stream handlers
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2026
Copilot AI changed the title [WIP] Extract SSE streams from gitops_operators.go Extract GitOps SSE handlers into dedicated stream module Jun 18, 2026
Copilot AI requested a review from clubanderson June 18, 2026 20:28
@clubanderson clubanderson deleted the copilot/extract-sse-streams branch June 19, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: no Indicates the PR's author has not signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants