Skip to content

Extract kubeconfig import/onboarding logic from pkg/agent/kube/client.go#19147

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/architect-extract-kubeconfig-import-onboarding
Closed

Extract kubeconfig import/onboarding logic from pkg/agent/kube/client.go#19147
Copilot wants to merge 2 commits into
mainfrom
copilot/architect-extract-kubeconfig-import-onboarding

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Adding or modifying a card/dashboard? Read the Card Development Guide first — it covers required patterns, common pitfalls, and the full file checklist.

New CNCF project card? New cards go in kubestellar/console-marketplace, not this repo. PRs adding new cards here will be redirected.

Use a coding agent. This repo is primarily developed with Claude Code (Opus 4.5/4.6). It knows all codebase patterns (isDemoData, useCardLoadingState, locale strings, DCO). Manual PRs that miss required patterns will be sent back.

📝 Summary of Changes

This refactor isolates kubeconfig import/preview and cluster onboarding responsibilities into a focused file, removing that concern from the core kube client implementation. Functional behavior is intentionally unchanged.

  • Kubeconfig onboarding extraction

    • Moved kubeconfig preview/import/onboarding paths from pkg/agent/kube/client.go to pkg/agent/kube/client_kubeconfig.go.
    • Included related types and helper logic used only by these flows.
  • Scoped helper relocation

    • Moved kubeconfig-only helpers (clustersEquivalent, authInfosEquivalent, uniqueName) with import logic to prevent orphaned onboarding internals in client.go.
  • Interface stability

    • Preserved method/type signatures consumed by HTTP handlers and tests.
// now lives in pkg/agent/kube/client_kubeconfig.go
func (k *KubectlProxy) ImportKubeconfig(yamlContent string) (added []string, skipped []string, err error)
func (k *KubectlProxy) PreviewKubeconfig(yamlContent string) ([]KubeconfigPreviewEntry, error)
func (k *KubectlProxy) AddCluster(req AddClusterRequest) error

Changes Made

  • Updated kube client file layout to separate kubeconfig onboarding concerns
  • Refactored kubeconfig preview/import/add-cluster implementations into client_kubeconfig.go
  • Fixed structural coupling by moving kubeconfig-only merge/comparison helpers with onboarding code
  • Added tests for new behavior (not applicable; behavior preserved)

Checklist

Please ensure the following before submitting your PR:

  • I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
  • I have reviewed the project's contribution guidelines
  • New cards target console-marketplace, not this repo
  • isDemoData is wired correctly (cards show Demo badge when using demo data) (N/A: non-card backend refactor)
  • I have written unit tests for the changes (if applicable)
  • I have tested the changes locally and ensured they work as expected
  • All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A (backend refactor; no UI/log artifact required).


👀 Reviewer Notes

  • This PR is intentionally structural: same logic, new file boundary.
  • Review focus: placement/scope of kubeconfig onboarding code and absence from client.go.

@kubestellar-prow kubestellar-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 18, 2026
@netlify

netlify Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 493c654
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a34535d27abf300080ac08a

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @Copilot — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

Signed-off-by: GitHub <noreply@github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubestellar-prow kubestellar-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2026
Copilot AI changed the title [WIP] Extract kubeconfig import and onboarding from client.go Extract kubeconfig import/onboarding logic from pkg/agent/kube/client.go Jun 18, 2026
Copilot AI requested a review from clubanderson June 18, 2026 20:22
@clubanderson clubanderson deleted the copilot/architect-extract-kubeconfig-import-onboarding branch June 19, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: no Indicates the PR's author has not signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants