Extract core resource handlers into pkg/api/handlers/mcp/resources_core.go#19142
Extract core resource handlers into pkg/api/handlers/mcp/resources_core.go#19142Copilot wants to merge 2 commits into
Conversation
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @Copilot — thanks for opening this PR!
This is an automated message. |
…core.go Move the three core-resource read handlers out of the catch-all resources.go (780 lines) into a focused resources_core.go, as requested in issue #19098. - No behaviour change; all shared helpers remain in place. - Build and go vet pass cleanly. - Existing TestListClusterResources tests pass. Fixes #19098 Signed-off-by: GitHub Copilot <copilot@github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
pkg/api/handlers/mcp/resources.gomixed too many concerns across 780 lines. This PR splits out the three core-resource read handlers into a focused file, per the scope defined in #19098.📝 Summary of Changes
GetConfigMaps,GetSecrets, andGetServiceAccountsfromresources.gointo a newresources_core.goChanges Made
pkg/api/handlers/mcp/resources_core.gowith the three core-resource handlerspkg/api/handlers/mcp/resources.goChecklist
Please ensure the following before submitting your PR:
git commit -s)Screenshots or Logs (if applicable)
N/A — no behaviour change.
👀 Reviewer Notes
Pure mechanical move; behaviour and all existing tests are unchanged.
go buildandgo vetpass cleanly on the affected package.