Skip to content

Extract core resource handlers into pkg/api/handlers/mcp/resources_core.go#19142

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/extract-core-resource-handlers
Closed

Extract core resource handlers into pkg/api/handlers/mcp/resources_core.go#19142
Copilot wants to merge 2 commits into
mainfrom
copilot/extract-core-resource-handlers

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

pkg/api/handlers/mcp/resources.go mixed too many concerns across 780 lines. This PR splits out the three core-resource read handlers into a focused file, per the scope defined in #19098.


📝 Summary of Changes

  • Moves GetConfigMaps, GetSecrets, and GetServiceAccounts from resources.go into a new resources_core.go
  • No logic changes — pure file reorganisation within the same package; all shared helpers remain in place

Changes Made

  • Created pkg/api/handlers/mcp/resources_core.go with the three core-resource handlers
  • Removed those three functions from pkg/api/handlers/mcp/resources.go

Checklist

Please ensure the following before submitting your PR:

  • I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
  • I have reviewed the project's contribution guidelines
  • New cards target console-marketplace, not this repo
  • isDemoData is wired correctly (cards show Demo badge when using demo data)
  • I have written unit tests for the changes (if applicable)
  • I have tested the changes locally and ensured they work as expected
  • All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A — no behaviour change.


👀 Reviewer Notes

Pure mechanical move; behaviour and all existing tests are unchanged. go build and go vet pass cleanly on the affected package.

@kubestellar-prow kubestellar-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 18, 2026
@netlify

netlify Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 2fb4557
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a3451c927abf300080a5109

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @Copilot — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2026
@github-actions github-actions Bot added tier/2-standard ai-generated Pull request generated by AI labels Jun 18, 2026
…core.go

Move the three core-resource read handlers out of the catch-all
resources.go (780 lines) into a focused resources_core.go, as
requested in issue #19098.

- No behaviour change; all shared helpers remain in place.
- Build and go vet pass cleanly.
- Existing TestListClusterResources tests pass.

Fixes #19098

Signed-off-by: GitHub Copilot <copilot@github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubestellar-prow kubestellar-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2026
Copilot AI changed the title [WIP] Extract core resource handlers from mcp_resources.go Extract core resource handlers into pkg/api/handlers/mcp/resources_core.go Jun 18, 2026
Copilot AI requested a review from clubanderson June 18, 2026 20:15
@clubanderson clubanderson deleted the copilot/extract-core-resource-handlers branch June 19, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: no Indicates the PR's author has not signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants