Skip to content

Guard KB Nightly issue creation when gap report is absent#19136

Closed
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-kb-nightly-validation-crash-again
Closed

Guard KB Nightly issue creation when gap report is absent#19136
Copilot wants to merge 2 commits into
mainfrom
copilot/fix-kb-nightly-validation-crash-again

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Adding or modifying a card/dashboard? Read the Card Development Guide first — it covers required patterns, common pitfalls, and the full file checklist.

New CNCF project card? New cards go in kubestellar/console-marketplace, not this repo. PRs adding new cards here will be redirected.

Use a coding agent. This repo is primarily developed with Claude Code (Opus 4.5/4.6). It knows all codebase patterns (isDemoData, useCardLoadingState, locale strings, DCO). Manual PRs that miss required patterns will be sent back.

📌 Fixes

Issue linking is handled automatically by the system.


📝 Summary of Changes

KB Nightly Validation was failing in the failure-reporting step because gh issue create --body-file kb-gap-report.md ran even when the file was never generated.
This change makes issue creation resilient by using --body-file only when the report exists and falling back to an inline body otherwise.


Changes Made

  • Updated .github/workflows/kb-nightly-validation.yml in the File issue on failure step
  • Refactored issue creation flow to guard --body-file behind if [ -f kb-gap-report.md ]
  • Fixed crash path by adding fallback --body text with run URL when no gap report is present
  • Added tests for this change (not applicable for this workflow-only fix)

Snippet (new guard):

if [ -f kb-gap-report.md ]; then
  gh issue create \
    --title "$TITLE" \
    --label "kb-gap,triage/needed,help wanted" \
    --body-file kb-gap-report.md
else
  gh issue create \
    --title "$TITLE" \
    --label "kb-gap,triage/needed,help wanted" \
    --body "KB Nightly Validation failed. No gap report was generated. See workflow run for details: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
fi

Checklist

Please ensure the following before submitting your PR:

  • I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
  • I have reviewed the project's contribution guidelines
  • New cards target console-marketplace, not this repo
  • isDemoData is wired correctly (cards show Demo badge when using demo data)
  • I have written unit tests for the changes (if applicable)
  • I have tested the changes locally and ensured they work as expected
  • All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A (workflow logic change only)


👀 Reviewer Notes

  • Scope is intentionally minimal: one workflow file, one failure-path guard.
  • No behavior change when kb-gap-report.md exists; only missing-file path is altered.

@kubestellar-prow kubestellar-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 18, 2026
@netlify

netlify Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit ad95396
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a344f8a8066ca0008288154

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @Copilot — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 18, 2026
Signed-off-by: GitHub <noreply@github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2026
Copilot AI changed the title [WIP] Fix KB Nightly Validation crash on missing kb-gap-report.md Guard KB Nightly issue creation when gap report is absent Jun 18, 2026
Copilot AI requested a review from clubanderson June 18, 2026 20:07
@clubanderson clubanderson deleted the copilot/fix-kb-nightly-validation-crash-again branch June 19, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: no Indicates the PR's author has not signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tier/3-restricted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants