ci: disable c8 coverage for Node 25 to work around yargs breakage#2785
Closed
Copilot wants to merge 2 commits intodependabot/npm_and_yarn/main/c8-11.0.0from
Closed
ci: disable c8 coverage for Node 25 to work around yargs breakage#2785Copilot wants to merge 2 commits intodependabot/npm_and_yarn/main/c8-11.0.0from
Copilot wants to merge 2 commits intodependabot/npm_and_yarn/main/c8-11.0.0from
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XS
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Bump c8 from version 10.1.3 to 11.0.0
ci: disable c8 coverage for Node 25 to work around yargs breakage
Mar 3, 2026
Contributor
|
Closing since this was handled via #2783 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c8depends onyargs, which is currently broken under Node.js 25 (nodejs/node#61971), causing CI to fail withReferenceError: require is not defined in ES module scope.Changes
.github/workflows/test.yml: For the Node 25 matrix entry, replacenpm test(which runsc8 node --test ...) with a directnode --test --test-reporter=spec --import tsx src/*_test.tsinvocation, skipping coverage collection. All other Node versions continue running with coverage viac8unchanged.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.