Read VSCode extension namespace from the manifest#383
Open
holodorum wants to merge 1 commit intokson-org:mainfrom
Open
Read VSCode extension namespace from the manifest#383holodorum wants to merge 1 commit intokson-org:mainfrom
holodorum wants to merge 1 commit intokson-org:mainfrom
Conversation
The upstream kson extension hard-coded "kson" as the prefix for its
contributed command ids (kson.selectSchema) and configuration
properties (kson.format.*, kson.codeLens.enable, kson.trace.server,
...).
The client now reads the namespace from a `ksonConfigNamespace`
top-level manifest field and then "kson", and passes it to the server
via initializationOptions. CommandType enum values are unqualified ids
(plainFormat, compactFormat, ...) with the wire prefix applied at the
LSP boundary via toWireCommandId / fromWireCommandId — both exported so
the client doesn't hand-build wire ids either. KsonSettings is flattened
to drop the fixed { kson: {...} } wrapper and a single
unwrapPushedSettings helper handles both namespaced and already-scoped
push payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream kson extension hard-coded "kson" as the prefix for its contributed command ids (kson.selectSchema) and configuration properties (kson.format.*, kson.codeLens.enable, kson.trace.server, ...).
The client now reads the namespace from a
ksonConfigNamespacetop-level manifest field, falling back to "kson", and passes it to the server via initializationOptions. CommandType enum values are unqualified ids (plainFormat, compactFormat, ...) with the wire prefix applied at the LSP boundary via toWireCommandId / fromWireCommandId — both exported so the client doesn't hand-build wire ids either. KsonSettings is flattened to drop the fixed { kson: {...} } wrapper and a single unwrapPushedSettings helper handles both namespaced and already-scoped push payloads.