Prevent formatter from throwing on malformed input with embed rules#382
Open
holodorum wants to merge 1 commit intokson-org:mainfrom
Open
Prevent formatter from throwing on malformed input with embed rules#382holodorum wants to merge 1 commit intokson-org:mainfrom
holodorum wants to merge 1 commit intokson-org:mainfrom
Conversation
The formatter parses with `ignoreErrors = true`, which can leave hidden `AstNodeError` nodes in a tree where `hasErrors()` still returns false. `resolveEmbedBlocks` called `root.toKsonValue()` directly, so those hidden errors surfaced as a `ShouldNotHappenException` that escaped `format()` instead of falling back to the original source. This only reproduced when embed block rules were configured. Take a `KsonValue` in `resolveEmbedBlocks` instead of a `KsonRoot`, and have the caller source it from `AstParseResult.ksonValue` — which already catches the conversion exception and returns null. The new `ksonValue != null` guard is strictly stronger than the previous `!hasErrors()` check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter parses with
ignoreErrors = true, which can leave hiddenAstNodeErrornodes in a tree wherehasErrors()still returns false.resolveEmbedBlockscalledroot.toKsonValue()directly, so those hidden errors surfaced as aShouldNotHappenExceptionthat escapedformat()instead of falling back to the original source. This only reproduced when embed block rules were configured.Take a
KsonValueinresolveEmbedBlocksinstead of aKsonRoot, and have the caller source it fromAstParseResult.ksonValue— which already catches the conversion exception and returns null. The newksonValue != nullguard is strictly stronger than the previous!hasErrors()check.