Add ktlint with auto-formatted codebase#366
Open
holodorum wants to merge 2 commits intokson-org:mainfrom
Open
Conversation
Apply org.jlleitschuh.gradle.ktlint (v14.2.0) to the root project and to Kotlin subprojects (via pluginManager.withPlugin so that non-Kotlin subprojects like lib-python and lib-rust are unaffected). The plugin's ktlintCheck task is automatically wired as a dependency of `check`. `./gradlew ktlintFormat` is available to auto-fix violations.
Fixed all linting errors. Most could get resolved by simply running `./gradlew ktlinterFormat`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
org.jlleitschuh.gradle.ktlintplugin (v14.2.0) to the root project and all Kotlin subprojects.checknow depends onktlintCheck, and./gradlew ktlintFormatis available for auto-fixing.This commit also contains the formats made by running
./gradlew ktlintFormatand some manual fixes to get./gradlew ktlintCheckto pass.I currently used the almost all the default rules of
ktlint(see the.editorconfig), if we want to disable any of the defaults we can change it there.