Feature/106405 physicalized dmgmethod improvements#389
Draft
FlufflesTheMicrosaur wants to merge 4 commits into
Draft
Conversation
…lear (proper naming) and separate out SDamageMethodAdj struct to its different usecases.
Ihlosi
reviewed
Jun 14, 2026
| // We also include periods in case of "pierce.5" and colons for "pierce:5" | ||
| else if (IsCharAlphaNumeric(*pC) || *pC == '.' || *pC == ':') | ||
| { | ||
| if (pNameEnd < pStart) |
Contributor
There was a problem hiding this comment.
The first time this block is entered pNameEnd is NULL.
A nullptr is not required to compare less than another pointer.
Recommend explicitly checking for NULL:
if ((pNameEnd == NULL) || (pNameEnd < pStart))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.