Emit JSON logs for logs-ingester compatibility#185
Merged
Conversation
Replace prettylog (colored text) with a slog JSON handler on stderr. Each line is now a single JSON object with a canonical "timestamp" in RFC3339Nano UTC plus a "service" field; traceId/name/namespace are already injected by unstructured-runtime. Handler logic inlined to avoid a plumbing bump that conflicts with the runtime's slogs/pretty test dep.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging configuration in
main.goto use structured JSON logs compatible with the logs-ingester system, replacing the previous pretty-printed log output. The change ensures that each log line is a single JSON object with a standardized timestamp, improving log parsing and integration with downstream systems.Logging improvements:
prettylogwith Go's standardslog.NewJSONHandler, outputting each log line as a JSON object tostderrwith a canonical "timestamp" field in RFC3339Nano UTC format for compatibility with logs-ingester.prettylogfrom the codebase, as it is no longer needed.Replace prettylog (colored text) with a slog JSON handler on stderr. Each line is now a single JSON object with a canonical "timestamp" in RFC3339Nano UTC plus a "service" field; traceId/name/namespace are already injected by unstructured-runtime. Handler logic inlined to avoid a plumbing bump that conflicts with the runtime's slogs/pretty test dep.